Merge lp:~camptocamp/partner-contact-management/partner_firstname_vre_view_resubmit into lp:~partner-contact-core-editors/partner-contact-management/7.0

[Vincent Renaville@camptocamp]

Hello,

I do a resubmit, I think it's more clear now.

Vincent

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Please don't mix tab and spaces and use spaces only

Why are label needed? Is it for some styling?
Isn't it possible to show the label by wrapping the fields in a <group> tag?

review: Needs Fixing (code)

[Vincent Renaville@camptocamp (vrenaville-c2c)]

Yannick tanks for the review,

I have done a resubmit to fit rev 26 .

I have add Is company on the contact for multiple level company,
and I remove the unuseful div on firstname lastname group

Vincent

[Holger Brunn (Therp) (hbrunn)]

review: Approve (code review)

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

review: Approve (code review, no tests)

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Thanks for the changes

[El Hadji Dem (http://www.savoirfairelinux.com) (eh-dem)]

Hello Vincent,

In partner view, we create a company; from the company, we create a contact and again you add is_company field; it is redundant and the view doesn't display well

review: Disapprove

=== modified file 'partner_firstname/partner_view.xml'
--- partner_firstname/partner_view.xml	2013-10-01 11:32:16 +0000
+++ partner_firstname/partner_view.xml	2013-11-13 16:20:40 +0000
@@ -32,10 +32,18 @@
           </group>
         </field>
         <!-- Add firstname and last name in inner contact form of child_ids -->
-        <xpath expr="//form[@string='Contact']/sheet/div/h1/field[@name='name']" position="after">
-            <field name="lastname"/>
+        <xpath expr="//form[@string='Contact']/sheet/div" position="after">
+           <group attrs="{'invisible': [('is_company', '=', True)]}">
+            <field name="lastname" attrs="{'required': [('is_company', '=', False)]}"/>
             <field name="firstname"/>
-        </xpath>
+           </group> 
+        </xpath>
+        <xpath expr="//form[@string='Contact']/sheet/div/h1" position="after">
+           <field name="is_company" on_change="onchange_type(is_company)" class="oe_inline"/>
+           <label for="is_company" string="Is a Company?"/>)
+        </xpath>
+
+
       </field>
     </record>