Merge lp:~camptocamp/partner-contact-management/partner_contact_management_display_name into lp:~partner-contact-core-editors/partner-contact-management/7.0

[Vincent Renaville@camptocamp]

overwrite field display_name or account_report_company in order to set the store function trigger with firstname and lastname

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

missing test

review: Needs Fixing (code review, no test)

[lp:~camptocamp/partner-contact-management/partner_contact_management_display_name]

22. By Vincent Renaville@camptocamp on 2013-07-15

[ADD] Test

23. By Vincent Renaville@camptocamp on 2013-07-15

[MRG] overwrite field display_name or account_report_company in order to set the store function trigger with firstname and lastname

24. By Vincent Renaville@camptocamp on 2013-07-15

[ADD] Test files for display_name field

[Vincent Renaville@camptocamp (vrenaville-c2c)]

Hello Alexandre,

Thanks for your review
I have just add a test for my patch.

Vincent

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

There is a pending MP with a link module which should already do the trick:

https://code.launchpad.net/~camptocamp/partner-contact-management/7.0-add-firstname_display_name_trigger/+merge/165354

This allows to install partner_firstname module even without account.

As an other way to solve this issue already exists I set it to disapprove.

This MP solves the following bug:
https://bugs.launchpad.net/partner-contact-management/+bug/1183319

review: Disapprove

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

> There is a pending MP with a link module which should already do the trick:
>
> https://code.launchpad.net/~camptocamp/partner-contact-management/7.0-add-
> firstname_display_name_trigger/+merge/165354
>
>
> This allows to install partner_firstname module even without account.
>
> As an other way to solve this issue already exists I set it to disapprove.
>
>
> This MP solves the following bug:
> https://bugs.launchpad.net/partner-contact-management/+bug/1183319
According to this comment I put the MP as 'rejected'. Thanks

Unmerged revisions

24. By Vincent Renaville@camptocamp on 2013-07-15

[ADD] Test files for display_name field

23. By Vincent Renaville@camptocamp on 2013-07-15

[MRG] overwrite field display_name or account_report_company in order to set the store function trigger with firstname and lastname

22. By Vincent Renaville@camptocamp on 2013-07-15

[ADD] Test

=== modified file 'partner_firstname/__openerp__.py'
--- partner_firstname/__openerp__.py	2013-02-20 12:43:45 +0000
+++ partner_firstname/__openerp__.py	2013-07-15 12:27:26 +0000
@@ -27,13 +27,16 @@
  'author': 'Camptocamp',
  'category': 'MISC',
  'website': 'http://www.camptocamp.com',
- 'depends': ['base'],
+ 'depends': ['base','account_report_company'],
  'data': [
      'partner_view.xml',
      'res_user_view.xml',
      ],
  'demo': [],
- 'test': [],
+ 'test': [
+        'test/res_partner_display_name.yml',
+    ],
+
  'auto_install': False,
  'installable': True,
  'images': []

=== modified file 'partner_firstname/partner.py'
--- partner_firstname/partner.py	2013-02-05 08:26:54 +0000
+++ partner_firstname/partner.py	2013-07-15 12:27:26 +0000
@@ -37,6 +37,13 @@
             res[rec['id']] = name
         return res
 
+    _display_name_store_triggers = {
+        'res.partner': (lambda self,cr,uid,ids,context=None: self.search(cr, uid, [('id','child_of',ids)]),
+                        ['parent_id', 'is_company', 'name','firstname','lastname'], 10)
+    }
+    # indirection to avoid passing a copy of the overridable method when declaring the function field
+    _display_name = lambda self, *args, **kwargs: self._display_name_compute(*args, **kwargs)
+
     def _write_name(self, cursor, uid, partner_id, field_name, field_value, arg, context=None):
         return self.write(cursor, uid, partner_id, {'lastname': field_value})
 
@@ -58,4 +65,5 @@
                                         fnct_inv=_write_name),
 
                 'firstname': fields.char("Firstname"),
+                'display_name': fields.function(_display_name, type='char', string='Name', store=_display_name_store_triggers),
                 'lastname': fields.char("Lastname", required=True)}

=== added directory 'partner_firstname/test'
=== added file 'partner_firstname/test/res_partner_display_name.yml'
--- partner_firstname/test/res_partner_display_name.yml	1970-01-01 00:00:00 +0000
+++ partner_firstname/test/res_partner_display_name.yml	2013-07-15 12:27:26 +0000
@@ -0,0 +1,23 @@
+-
+  !record {model: 'res.partner', id: partner_firstname.test_user1}:
+    function: Service Manager
+    email: [e-mail]
+    firstname: Tang
+    lastname: Tsui
+-
+  !record {model: 'res.partner', id: partner_firstname.test_user2}:
+    parent_id: partner_firstname.test_user1
+    use_parent_address: True
+    function: Store Manager
+    email: [e-mail]
+    firstname: Joseph
+    lastname: Walters
+-
+  I check that Initially supplier invoice state is "Draft"
+-
+  !assert {model: res.partner, id: partner_firstname.test_user1}:
+    - display_name == 'Tsui Tang'
+  
+-
+  !assert {model: res.partner, id: partner_firstname.test_user2}:
+    - display_name == 'Tsui Tang, Walters Joseph'