Code review comment for lp:~camptocamp/partner-contact-management/city_into_better_zip

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Nicolas,

Thanks for the work. These are my comments to your MP:

- 'ZIP Management' must be inside Configuration > Address book > Localization for better organization.
- 'ZIP Management' and 'ZIP completion' may not reflect the exact meaning of the function, because the completion is not only for the ZIP, but for the city, state and state fields. Why don't use 'Cities' and 'Location'?
- Please separate elements with commas instead spaces in name_get method of 'res.better.zip' for better understanding (specially with compound names).
- For what is used priority field? I think that now it's not necessary, doesn't it?

About the contributions lines, please change my email to the commercial one (<email address hidden>) and include also Ignacio Ibeas (<email address hidden>), that has contributed to the new city module.

When we decide all these things (and maybe the eventual module name change), I'll make the translation to spanish. We can also publish a pot file to let Launchpad manage translations.

Regards.

review: Needs Fixing

« Back to merge proposal