Partner and Contact Management

Merge lp:~camptocamp/partner-contact-management/7.0-fix_partner_contact_address_detailed into lp:~partner-contact-core-editors/partner-contact-management/7.0

  1. 7.0-fix_partner_contact_address_detailed
  2. Merge into 7.0
Proposed by Alexandre Fayolle - camptocamp
Status: Merged
Approved by: Guewen Baconnier @ Camptocamp
Approved revision: 20
Merged at revision: 20
Proposed branch: lp:~camptocamp/partner-contact-management/7.0-fix_partner_contact_address_detailed
Merge into: lp:~partner-contact-core-editors/partner-contact-management/7.0
Diff against target: 12 lines (+1/-1)
1 file modified
partner_contact_address_detailed/partner_view.xml (+1/-1)
To merge this branch: bzr merge lp:~camptocamp/partner-contact-management/7.0-fix_partner_contact_address_detailed
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp Approve
Yannick Vaucher @ Camptocamp code Approve
Vincent Renaville@camptocamp (community) Approve
Review via email: mp+163882@code.launchpad.net

Description of the change

[FIX] partner_contact_address_detailed: adapt partner form inherit to new partner form

To post a comment you must log in.
Revision history for this message
Vincent Renaville@camptocamp (vrenaville-c2c) wrote :

Seems good to me

review: Approve
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

good thing to increase the strength of the xpath

review: Approve (code)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Is there any bug report about what it fixes ?

Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

> Is there any bug report about what it fixes ?

bug report created and linked

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'partner_contact_address_detailed/partner_view.xml'
2--- partner_contact_address_detailed/partner_view.xml 2013-02-04 13:59:47 +0000
3+++ partner_contact_address_detailed/partner_view.xml 2013-05-15 09:46:41 +0000
4@@ -5,7 +5,7 @@
5 <field name="model">res.partner</field>
6 <field name="inherit_id" ref="base.view_partner_form"/>
7 <field name="arch" type="xml">
8- <xpath expr="//page[@string='Contacts']/field/form/div/group/field[@name='mobile']" position="after">
9+ <xpath expr="//page[@string='Contacts']//field[@name='mobile']" position="after">
10 <label for="type"/>
11 <div colspan="2">
12 <field name="type"/>

Subscribers

People subscribed via source and target branches

to status/vote changes: