Merge lp:~camptocamp/openobject-server/7.0-registrymanager-rlock-1238560-gbr into lp:openobject-server/7.0

[Guewen Baconnier @ Camptocamp]

[FIX] missing a threading.RLock in RegistryManager.get():

If no registry exists and several calls to RegistryManager.get() are called at the same time by several threads, several registries will be created one after the other and only the last one will be kept in cls.registries

Fixes: https://bugs.launchpad.net/openobject-server/+bug/1238560

[Martin Trigaux (OpenERP) (mat-openerp)]

Merged in 7.0, thanks for the patch

revno: 5129 [merge]
revision-id: <email address hidden>

review: Approve

=== modified file 'openerp/modules/registry.py'
--- openerp/modules/registry.py	2013-03-01 18:25:10 +0000
+++ openerp/modules/registry.py	2013-10-11 09:31:34 +0000
@@ -185,15 +185,16 @@
     @classmethod
     def get(cls, db_name, force_demo=False, status=None, update_module=False):
         """ Return a registry for a given database name."""
-        try:
-            return cls.registries[db_name]
-        except KeyError:
-            return cls.new(db_name, force_demo, status,
-                           update_module)
-        finally:
-            # set db tracker - cleaned up at the WSGI
-            # dispatching phase in openerp.service.wsgi_server.application
-            threading.current_thread().dbname = db_name
+        with cls.registries_lock:
+            try:
+                return cls.registries[db_name]
+            except KeyError:
+                return cls.new(db_name, force_demo, status,
+                               update_module)
+            finally:
+                # set db tracker - cleaned up at the WSGI
+                # dispatching phase in openerp.service.wsgi_server.application
+                threading.current_thread().dbname = db_name
 
     @classmethod
     def new(cls, db_name, force_demo=False, status=None,