Merge lp:~camptocamp/openobject-addons/opening_entry_foreign_currency_fix_mdh into lp:openobject-addons/7.0
Status: | Merged |
---|---|
Merged at revision: | 9756 |
Proposed branch: | lp:~camptocamp/openobject-addons/opening_entry_foreign_currency_fix_mdh |
Merge into: | lp:openobject-addons/7.0 |
Diff against target: |
27 lines (+1/-9) 1 file modified
account/wizard/account_fiscalyear_close.py (+1/-9) |
To merge this branch: | bzr merge lp:~camptocamp/openobject-addons/opening_entry_foreign_currency_fix_mdh |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Trigaux (OpenERP) (community) | Approve | ||
Leonardo Pistone (community) | code review | Approve | |
Review via email: mp+197539@code.launchpad.net |
Commit message
[FIX] correct amount for opening entry in foreign currency
Description of the change
Found this issue: when computing an opening entry, the move lines' domains differ between the amount in system currency (all move lines in the latest FY before the current one, for example FY2012) and the amount in foreign currency (all move lines in previous FY, for example FY2012, 2011, 2010...).
I removed the old method to retrieve the sum of foreign amounts, which used a domain of multiple FYs, and retrieved the correct sum by using the function field "foreign_balance" in the account (since a single FY is specified in the browse() context, only the balance for this FY is retrieved; this is how the correct "account.balance" works).
LGTM
Thanks Matthieu