Merge lp:~camptocamp/openobject-addons/7.0-fix_mail_auto_subscribe-1188538 into lp:openobject-addons/7.0

Proposed by Guewen Baconnier @ Camptocamp
Status: Rejected
Rejected by: Martin Trigaux (OpenERP)
Proposed branch: lp:~camptocamp/openobject-addons/7.0-fix_mail_auto_subscribe-1188538
Merge into: lp:openobject-addons/7.0
Diff against target: 19 lines (+1/-2)
1 file modified
mail/mail_thread.py (+1/-2)
To merge this branch: bzr merge lp:~camptocamp/openobject-addons/7.0-fix_mail_auto_subscribe-1188538
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+167934@code.launchpad.net

Commit message

[FIX] automatically subscribe users from fields even if the field has no 'track_visibility' defined.

This condition prevented to register new fields given in the 'auto_follow_fields' arguments if they had no 'track_visibility', which is unrelated to the automatic subscription

Description of the change

To post a comment you must log in.
Revision history for this message
Martin Trigaux (OpenERP) (mat-openerp) wrote :

As mentioned on the bug report, not the behaviour we would like to have.
I reject this merge proposal then

Regards

Unmerged revisions

9203. By Guewen Baconnier @ Camptocamp

[FIX] automatically subscribe users from fields even if the field has no 'track_visibility' defined.

This condition prevented to register new fields given in the 'auto_follow_fields' arguments if they had no 'track_visibility', which is unrelated to the automatic subscription

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'mail/mail_thread.py'
2--- mail/mail_thread.py 2013-05-29 14:30:22 +0000
3+++ mail/mail_thread.py 2013-06-07 09:40:20 +0000
4@@ -1215,7 +1215,6 @@
5 trigger an auto subscribe. The default list checks for the fields
6 - called 'user_id'
7 - linking to res.users
8- - with track_visibility set
9 In OpenERP V7, this is sufficent for all major addon such as opportunity,
10 project, issue, recruitment, sale.
11 Override this method if a custom behavior is needed about fields
12@@ -1223,7 +1222,7 @@
13 """
14 user_field_lst = []
15 for name, column_info in self._all_columns.items():
16- if name in auto_follow_fields and name in updated_fields and getattr(column_info.column, 'track_visibility', False) and column_info.column._obj == 'res.users':
17+ if name in auto_follow_fields and name in updated_fields and column_info.column._obj == 'res.users':
18 user_field_lst.append(name)
19 return user_field_lst
20