Merge lp:~camptocamp/openobject-addons/7.0-fix-report_webkit-descriptor-20130211 into lp:openobject-addons/7.0

Proposed by Yannick Vaucher @ Camptocamp on 2013-02-11
Status: Merged
Approved by: Naresh(OpenERP) on 2013-06-07
Approved revision: no longer in the source branch.
Merged at revision: 9308
Proposed branch: lp:~camptocamp/openobject-addons/7.0-fix-report_webkit-descriptor-20130211
Merge into: lp:openobject-addons/7.0
Diff against target: 15 lines (+3/-2)
1 file modified
report_webkit/__openerp__.py (+3/-2)
To merge this branch: bzr merge lp:~camptocamp/openobject-addons/7.0-fix-report_webkit-descriptor-20130211
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) 2013-02-11 Approve on 2013-06-07
Niels Huylebroeck (community) Approve on 2013-02-14
Alexandre Fayolle - camptocamp (community) code review, no test Approve on 2013-02-14
Review via email: mp+147625@code.launchpad.net

Description of the change

Fixes misleading information in __openerp__.py descriptor for configuration of wkhtmltopdf librairy path.

This is the same MP as the following for 6.1:

https://code.launchpad.net/~camptocamp/openobject-addons/6.1-report_webkit-20120509/+merge/105225

Please merge it, it is important and it only touch the description.

To post a comment you must log in.

LGTM.

review: Approve (code review, no test)
Niels Huylebroeck (red15) wrote :

Worth noting it also checks the path environment variable to see if it can find the wkhtmltopdf binary.

On that note I would like to point out if you use the openerp.init script in the debian sub-dir of the server that the path does NOT include things like /usr/local/bin (where we usually like to install custom software on a production machine)

review: Approve
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'report_webkit/__openerp__.py'
2--- report_webkit/__openerp__.py 2012-11-29 22:26:45 +0000
3+++ report_webkit/__openerp__.py 2013-02-11 10:52:27 +0000
4@@ -62,8 +62,9 @@
5 PDF. Version 0.9.9 or later is necessary, and can be found at
6 http://code.google.com/p/wkhtmltopdf/ for Linux, Mac OS X (i386) and Windows (32bits).
7
8-After installing the library on the OpenERP Server machine, you need to set the
9-path to the ``wkthtmltopdf`` executable file on each Company.
10+After installing the library on the OpenERP Server machine, you need to set
11+the path to the ``wkthtmltopdf`` executable file in a system parameter named ``webkit_path``
12+in Settings -> Customization -> Low Level Object -> System Parameters
13
14 If you are experiencing missing header/footer problems on Linux, be sure to
15 install a 'static' version of the library. The default ``wkhtmltopdf`` on