Merge lp:~camptocamp/openobject-addons/7.0-fix-do-partial-picking-20130425 into lp:openobject-addons/7.0

[Yannick Vaucher @ Camptocamp]

Fixes trying to make partial_data with False value as move ID in case of partial line without move_id

[Amit Parik (amit-parik)]

Hello Yannick,

move_id and wizard_line.move_id.id both are same, see the line#170 move_id = wizard_line.move_id.id under the for wizard_line in partial.move_ids. So when there is no partial move id it will not exceute this code.

Also both have same value. So I didn't see any issue here. Hance the bug will be closed and I am rejecting the MP.
More comment on bug.

Thank you!

review: Disapprove

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Of course there is move_id = wizard_line.move_id.id
However, wizard_line.move_id.id can be false, move_id cannot as it is set when a move is created if move_id is false.

In http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/view/head:/stock/wizard/stock_partial_picking.py

Let's say wizard_line.move_id is false

l170 move_id = wizard_line.move_id.id # we set false to move_id
...
l182 if move_id: # we do not enter here
...
l193 else: # but here
# so we create a new move and assign move_id
l195 move_id = stock_move.create(cr,uid,{'name' : self.pool.get('ir.sequence').get(cr, uid, seq_obj_name),

# here we use wizard_line.move_id.id which is false
l211 if (picking_type == 'in') and (wizard_line.product_id.cost_method == 'average'):
l212 partial_data['move%s' % (wizard_line.move_id.id)].update(product_price=wizard_line.cost,
l213 product_currency=wizard_line.currency.id)

--> Error as partial_data['movefalse'] doesn't exists

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

As per Amit comment on 2013-07-31 in bug report: review status isn't up to date

[Amit Parik (amit-parik)]

Ok, now its fine for me!

review: Approve

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Thanks for the review Amit

Unmerged revisions

9074. By Yannick Vaucher @ Camptocamp on 2013-04-25

[FIX] wrong variable used to construct partial_data in partial_picking wizard in do_partial_picking

=== modified file 'stock/wizard/stock_partial_picking.py'
--- stock/wizard/stock_partial_picking.py	2012-12-17 15:23:03 +0000
+++ stock/wizard/stock_partial_picking.py	2013-04-25 12:44:26 +0000
@@ -209,7 +209,7 @@
                 'prodlot_id': wizard_line.prodlot_id.id,
             }
             if (picking_type == 'in') and (wizard_line.product_id.cost_method == 'average'):
-                partial_data['move%s' % (wizard_line.move_id.id)].update(product_price=wizard_line.cost,
+                partial_data['move%s' % (move_id)].update(product_price=wizard_line.cost,
                                                                   product_currency=wizard_line.currency.id)
         stock_picking.do_partial(cr, uid, [partial.picking_id.id], partial_data, context=context)
         return {'type': 'ir.actions.act_window_close'}