Merge lp:~camptocamp/openobject-addons/7.0-fix-1308364-nbi into lp:openobject-addons/7.0

Proposed by Nicolas Bessi - Camptocamp
Status: Needs review
Proposed branch: lp:~camptocamp/openobject-addons/7.0-fix-1308364-nbi
Merge into: lp:openobject-addons/7.0
Diff against target: 11 lines (+1/-0)
1 file modified
report_webkit/webkit_report.py (+1/-0)
To merge this branch: bzr merge lp:~camptocamp/openobject-addons/7.0-fix-1308364-nbi
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp (community) code review, no test Approve
Romain Deheele - Camptocamp (community) code review Approve
OpenERP Core Team Pending
Review via email: mp+216016@code.launchpad.net

Description of the change

Fix support of set_context for webkit precise_mode

To post a comment you must log in.
Revision history for this message
Romain Deheele - Camptocamp (romaindeheele) wrote :

It LGTM.
Thanks Nicolas,

Romain

review: Approve (code review)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) :
review: Approve (code review, no test)

Unmerged revisions

9841. By Nicolas Bessi - Camptocamp on 2014-04-16

[FIX] report_webkit precise mode to support set_context hook

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'report_webkit/webkit_report.py'
2--- report_webkit/webkit_report.py 2014-03-24 10:17:31 +0000
3+++ report_webkit/webkit_report.py 2014-04-16 07:25:01 +0000
4@@ -254,6 +254,7 @@
5 body_mako_tpl = mako_template(template)
6 helper = WebKitHelper(cursor, uid, report_xml.id, context)
7 if report_xml.precise_mode:
8+ objs = self.parser_instance.localcontext['objects']
9 for obj in objs:
10 self.parser_instance.localcontext['objects'] = [obj]
11 try :