Code review comment for lp:~camptocamp/openobject-addons/6.1-opening-entry-fix-mdh

Revision history for this message
Leonardo Pistone (lepistone) wrote :

I have a doubt about """if account.currency_id.id else 0.0"""

If the currency_id field is empty, then if I remember correctly, account.currency_id is a browse_null
object, something that should be False when cast to boolean. On the other hand, I am not sure that account.currency_id.id will work.

I suggest changing that line to """if account.currency_id else 0.0"""

Thanks

review: Needs Information

« Back to merge proposal