Code review comment for lp:~camptocamp/openerp-swiss-localization/7.0-wip-invoice-ref-transaction-id

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

> Customer invoices creation :
>
> * BVR number is populated on all account move lines. it is no relevant. We
> should only have this information on the account move line containing the same
> account_id than the one indicated on the related invoice.

Done (as well as for the transaction ids branch [0])

>
> * The field call reference on the SO (and the webkit pdf also) becomes a
> description on the invoice and the move line. I suggest to call it description
> everywhere.
> note that on the webkit invoice this information appears twice under the name
> Subject & You reference... which is not ideal as well

I won't rename the fields. This is the field name used by OpenERP and we should keep it even if it is bad, changing it will break the translations. We have 2 possible courses of action here: 1) propose a new name for the next OpenERP release and 2) change the name in a custom translation.

The "Your Reference" field is now hidden when both fields have the same content.
This is done in the account-invoice-report project [1].

>
> * Bank statement with all swiss modules :
> -> button 'import invoice' : no BVR no populated into the transaction ref

Done in a new compatibility module (autoinstallable) account_payment_transaction_id because the base_transaction_id module has no dependency on account_voucher / account_payment. It unfortunately requires the module "statement_voucher_killer" because this module redefine the wizards. I would have preferred this module to work with *and* without "statement_voucher_killer" though but the use case I'm covering here use it.

This is done in the generic MP [0], not in the swiss localization.

> -> button 'import payment lines' : no BVR no populated into the transaction
> ref (but ok in payment lines)

Added in account_payment_transaction_id (same remark than above).

> - butoon 'import BVR' - transaction ref is correctely populated but I should
> have the invoice number into the field 'reference' and a / into
> 'communication' (currentely it is the other way around so it is not consistent
> with all the new logic in place)

Done.

>
> Thanks
>
> Frederic

[0] https://code.launchpad.net/~camptocamp/banking-addons/7.0-bank-statement-reconcile-transaction_id-imp/+merge/202806
[1] https://code.launchpad.net/~camptocamp/account-invoice-report/7.0-invoice-webkit-hide-identical-ref/+merge/209436

« Back to merge proposal