Merge lp:~camptocamp/openerp-swiss-localization/6.1-fix-1108936 into lp:~camptocamp/openerp-swiss-localization/6.1

[Yannick Vaucher @ Camptocamp]

[FIX] Restore default behavior of bank field. Call onchange_bank_id when the bank field is modified. Display the bank field only if the user is in group_extended

Some whitespace clean up
+
Fix onchange in res_partner_bank view form

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

note : the MP does 2 different things and the commit messages should reflect this:

1. the bank field is not always displayed
2. when it is displayed, then an onchange is added

(plus various whitespace cleanups cluttering the diff)

LGTM

review: Approve

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

> note : the MP does 2 different things and the commit messages should reflect
> this:

I updated the suggested commit message for the merge. Feel free to edit if required.

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Hello thanks for the review. Your commit message LGTM :)

Or perhaps we should specify that we restore the default behavior of this field.

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

> Hello thanks for the review. Your commit message LGTM :)
>
> Or perhaps we should specify that we restore the default behavior of this
> field.

Ah ok, I was not aware of this aspect of things.

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Feel free to merge it when you can :)

=== modified file 'l10n_ch/bank_view.xml'
--- l10n_ch/bank_view.xml	2012-06-28 13:11:31 +0000
+++ l10n_ch/bank_view.xml	2013-01-29 14:47:41 +0000
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <openerp>
     <data>
-        <!-- res.bank base form-->    
+        <!-- res.bank base form-->
         <record model="ir.ui.view" id="view_res_bank_form">
             <field name="name">res.bank.form</field>
             <field name="model">res.bank</field>
@@ -16,7 +16,7 @@
                 </field>
             </field>
         </record>
-        
+
         <!-- res.bank base tree-->
         <record model="ir.ui.view" id="l10nch_view_res_bank_tree">
             <field name="name">res.bank.tree</field>
@@ -30,10 +30,10 @@
                 </field>
             </field>
         </record>
-        
+
         <!-- res.partner.bank in res partner form-->
         <!-- Partner -> Bank Details -->
-        
+
         <record model="ir.ui.view" id="l10nch_view_res_partner_bank_hide_f1">
             <field name="name">res.partner_bank.form.hide.f1</field>
             <field name="model">res.partner</field>
@@ -54,7 +54,7 @@
                 </field>
             </field>
         </record>
-        
+
         <record model="ir.ui.view" id="l10nch_view_res_partner_bank_add_groups">
             <field name="name">res.partner_bank.form.hide.f2</field>
             <field name="model">res.partner</field>
@@ -102,7 +102,7 @@
             <field name="type">form</field>
             <field name="inherit_id" ref="base.view_partner_bank_form"/>
             <field name="arch" type="xml">
-                <field name="bank" position="replace"> 
+                <field name="bank" position="replace">
                 </field>
             </field>
         </record>
@@ -115,7 +115,7 @@
             <field name="arch" type="xml">
                 <field name="state" position="after">
                     <newline/>
-                    
+
                     <separator colspan="4" string="Account infos"/>
                         <newline/>
                     <group string="Bank account info" colspan="4" attrs="{'invisible': [('state','in', ['bvpost','bvrpost'])]}" >
@@ -141,10 +141,10 @@
                         </group>
                     </group>
                     <newline/>
-                    <field name="bank" />
+                    <field name="bank" on_change="onchange_bank_id(bank)" groups="base.group_extended"/>
                 </field>
             </field>
-        </record>        
+        </record>
 
         <!-- res.partner form bank list-->
         <!-- Adding Type and bank name -->
@@ -156,11 +156,11 @@
             <field name="arch" type="xml">
                 <xpath expr="/form/notebook/page/field[@name='bank_ids']/tree/field[@name='acc_number']" position="before">
                     <field name="state" />
-                    <field name="bank" /> 
+                    <field name="bank" />
                 </xpath>
             </field>
         </record>
-        
+
         <!-- res.partner form bank list-->
         <!-- Adding Type and bank name -->
         <record id="l10nch_view_partner_bank_invoice_tree" model="ir.ui.view">
@@ -171,8 +171,8 @@
             <field name="arch" type="xml">
                 <field name="acc_number" position="before">
                     <field name="state" />
-                    <field name="bank" />
-                </field> 
+                    <field name="bank" on_change="onchange_bank_id(bank)" groups="base.group_extended"/>
+                </field>
             </field>
         </record>