Merge lp:~camptocamp/openerp-rma/7.0-crm_claim_rma-fix-lp1317045_rde into lp:~openerprma/openerp-rma/7.0

Proposed by Romain Deheele - Camptocamp
Status: Needs review
Proposed branch: lp:~camptocamp/openerp-rma/7.0-crm_claim_rma-fix-lp1317045_rde
Merge into: lp:~openerprma/openerp-rma/7.0
Diff against target: 12 lines (+1/-1)
1 file modified
crm_claim_rma/wizard/claim_make_picking.py (+1/-1)
To merge this branch: bzr merge lp:~camptocamp/openerp-rma/7.0-crm_claim_rma-fix-lp1317045_rde
Reviewer Review Type Date Requested Status
Joël Grand-Guillaume @ camptocamp code review + test Approve
Review via email: mp+218595@code.launchpad.net

Description of the change

Hello,

It fixes https://bugs.launchpad.net/openerp-rma/+bug/1317045
Set the correct partner_id on picking when we generate a new product return from a claim.

Regards,

Romain

To post a comment you must log in.
Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi Romain,

Thanks for the fix, after testing and looking with other customers uses cases, I approve this improvement.

Regards

review: Approve (code review + test)
Revision history for this message
Benoit Guillot - http://www.akretion.com (benoit-guillot-z) wrote :

Hello Romain,

I think your change is right, it's good to put the partner who send the product in the field partner_id.

There is one use case that we might consider.
If we want to create a delivery label that the customer can print to return the product, in this case we don't have the information of the address on the picking.
One solution would be to print it from the claim.

There is maybe some others cases where it can be useful to have this information on the picking.

Should we consider to keep the return partner on the picking on another field ?

Regards,

Revision history for this message
Romain Deheele - Camptocamp (romaindeheele) wrote :

Hello Benoit,

FYI, the return address remains available on the field partner_id on... stock.move object :(
the help on this field describes :"Optional address where goods are to be delivered, specifically used for allotment""
and crm_claim_rma forces you to have the same address on lines used to generate the return picking.
On my side, I added a new report on stock.picking to print a return picking (because it was very specific : landscape and other details).
but, in the generic case, you point out a case that deserves to be clearer : should we use the standard picking report or one new report?
Joel, what do you think about it?

Thanks,

Romain

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

This project is now hosted on https://github.com/OCA/rma. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

Unmerged revisions

79. By Romain Deheele - Camptocamp on 2014-05-07

[FIX] partner_id on return picking is logically the claim partner_id

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'crm_claim_rma/wizard/claim_make_picking.py'
2--- crm_claim_rma/wizard/claim_make_picking.py 2014-04-08 19:41:50 +0000
3+++ crm_claim_rma/wizard/claim_make_picking.py 2014-05-07 11:41:18 +0000
4@@ -211,7 +211,7 @@
5 'move_type': 'one', # direct
6 'state': 'draft',
7 'date': time.strftime(DEFAULT_SERVER_DATETIME_FORMAT),
8- 'partner_id': partner_id,
9+ 'partner_id': claim.partner_id.id,
10 'invoice_state': "none",
11 'company_id': claim.company_id.id,
12 'location_id': wizard.claim_line_source_location.id,

Subscribers

People subscribed via source and target branches