Merge lp:~camptocamp/openerp-product-attributes/7.0-no-attribute_id-on-option-creation-gbr into lp:~product-core-editors/openerp-product-attributes/7.0
Proposed by
Guewen Baconnier @ Camptocamp
Status: | Merged |
---|---|
Merged at revision: | 222 |
Proposed branch: | lp:~camptocamp/openerp-product-attributes/7.0-no-attribute_id-on-option-creation-gbr |
Merge into: | lp:~product-core-editors/openerp-product-attributes/7.0 |
Diff against target: |
56 lines (+28/-0) 2 files modified
base_custom_attributes/custom_attributes.py (+1/-0) base_custom_attributes/custom_attributes_view.xml (+27/-0) |
To merge this branch: | bzr merge lp:~camptocamp/openerp-product-attributes/7.0-no-attribute_id-on-option-creation-gbr |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Raphaël Valyi - http://www.akretion.com | Approve | ||
Quentin THEURET @Amaris (community) | code review | Approve | |
Review via email: mp+188628@code.launchpad.net |
Commit message
[IMP] when creating a new option on a 'selection' attribute, the attribute_id should be pre-filled with the current attribute id and should not be editable
Description of the change
When we are editing a product and want to add a new option to an attribute,
actually, the form view for the option asks for the attribute despite the fact
that we come from an attribute.
This change does 2 things:
* fills the attribute_id of the option with the attribute we come from
* hide the attribute_id from the form view (but keep it displayed when accessed from the menu 'Attribute Options')
To post a comment you must log in.
LGTM