Merge lp:~camptocamp/openerp-product-attributes/7.0-fix_1296605-afe into lp:~product-core-editors/openerp-product-attributes/7.0

Proposed by Alexandre Fayolle - camptocamp
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 235
Merged at revision: 235
Proposed branch: lp:~camptocamp/openerp-product-attributes/7.0-fix_1296605-afe
Merge into: lp:~product-core-editors/openerp-product-attributes/7.0
Diff against target: 19 lines (+2/-2)
1 file modified
customer_context_in_product_view/partner_pricelist_view.xml (+2/-2)
To merge this branch: bzr merge lp:~camptocamp/openerp-product-attributes/7.0-fix_1296605-afe
Reviewer Review Type Date Requested Status
Graeme Gellatly Approve
Yannick Vaucher @ Camptocamp Approve
Leonardo Pistone code review Approve
Nicolas Bessi - Camptocamp (community) no test, code review Approve
Guewen Baconnier @ Camptocamp Approve
Review via email: mp+212372@code.launchpad.net

Description of the change

customer_context_in_product_view: fix oid in view

To post a comment you must log in.
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Thanks

review: Approve
Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote :

LGTM

review: Approve (no test, code review)
Revision history for this message
Leonardo Pistone (lepistone) wrote :

OK!
Small thing: I don't undertand the way the diff is displayed about the last line: you fixed the missing newline or you took it out?

review: Approve (code review)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Leonardo I would say a end of line was added.

Thanks Alexandre LGTM

review: Approve
Revision history for this message
Graeme Gellatly (gdgellatly) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'customer_context_in_product_view/partner_pricelist_view.xml'
2--- customer_context_in_product_view/partner_pricelist_view.xml 2014-02-14 21:09:26 +0000
3+++ customer_context_in_product_view/partner_pricelist_view.xml 2014-03-24 09:52:31 +0000
4@@ -30,7 +30,7 @@
5 <field name="priority" eval="20"/>
6 <field name="arch" type="xml">
7 <xpath expr="//div[@name='buttons']" position="inside">
8- <button name="%(partner_price_in_product_view.act_res_partner_pricing)d" type="action"
9+ <button name="%(customer_context_in_product_view.act_res_partner_pricing)d" type="action"
10 string="Product Pricing" groups="base.group_sale_salesman"
11 attrs="{'invisibile': [('customer', '=', 'False')]}"/>
12 </xpath>
13@@ -38,4 +38,4 @@
14 </record>
15
16 </data>
17-</openerp>
18\ No newline at end of file
19+</openerp>

Subscribers

People subscribed via source and target branches