Merge lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_one-2-lep into lp:openerp-manufacturing/6.1

[Leonardo Pistone]

Hi,

this is to add a new module: mrp_split_one.

Thanks!

[Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter)]

__openerp__.py:
The 1 space indentation doesn't meet pep8 criteria.
l.58 Spelling mistake of 'prodution' in description

stock.py:
l.126-127 Should be importing from openerp.osv, openerp.tools... (see mrp_bom_product_details/mrp_bom_product_details.py)

review: Needs Fixing (code review)

[lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_one-2-lep]

9. By Leonardo Pistone on 2013-12-04

[fix] typo

[Leonardo Pistone (lepistone)]

Sandy,
thanks for your review.

1. I think that case falls under the "Aligned with opening delimiter" rule, which should be fine. The pep8 tool indeed likes it.

2. fixed.

3. I think this is 7.0 style, while all but one of the 6.1 standard modules do "from osv".

Best

[Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter)]

1. Technically, you are correct, while I don't personally like that style, as most __openerp__.py files won't start the item list on the same line as opening brace, I don't see this as reason to block the MP.

LGTM

review: Approve (code review, no test)

[lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_one-2-lep]

10. By Leonardo Pistone on 2013-12-12

[imp] poor man's refresh

[Leonardo Pistone (lepistone)]

I added a "poor man's refresh" so that the whole MO is refreshed when my button is pressed, and we can see the new line we created as well.

This seems to work, but please let me know if it makes sense to you.

Thanks!

[lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_one-2-lep]

11. By Leonardo Pistone on 2013-12-16

[add] i18n

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

l265 missing context propagation

fr po file should be named fr.po instead of fr_FR.po otherwise I suspect that fr translation won't be loaded

Could you can also translate those terms:

msgid "Quantity needs to be more that 1."
msgstr "La quantité doit être plus grande que 1."

msgid "You can not move products from or to a location of the type view."
msgstr "Vous ne pouvez pas déplacer un produit vers ou depuis un emplacement de type vue."

msgid "Error"

l249 orm.Model instead of osv.osv (already deprecated in 6.1)

review: Needs Fixing (code review, no tests)

[lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_one-2-lep]

12. By Leonardo Pistone on 2014-01-17

[imp] context propagation, new-style model, docstrings

13. By Leonardo Pistone on 2014-01-17

[imp] split one: translations

[Leonardo Pistone (lepistone)]

Thanks for your review Yannick. Fixed.

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Please use full path for import

from openerp.osv import orm

review: Needs Fixing (code review, no tests)

[lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_one-2-lep]

14. By Leonardo Pistone on 2014-01-17

[fix] import

15. By Leonardo Pistone on 2014-01-17

[imp] noqa

[Leonardo Pistone (lepistone)]

fixed, thanks

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Hi,

Thanks for the contribs ! LGTM

Joël

review: Approve (code review, no tests)

=== added directory 'mrp_split_one'
=== added file 'mrp_split_one/__init__.py'
--- mrp_split_one/__init__.py	1970-01-01 00:00:00 +0000
+++ mrp_split_one/__init__.py	2014-01-17 11:03:38 +0000
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#                                                                             #
+#   Author: Leonardo Pistone <[e-mail]>                #
+#   Copyright 2013 Camptocamp SA                                              #
+#                                                                             #
+#   This program is free software: you can redistribute it and/or modify      #
+#   it under the terms of the GNU Affero General Public License as            #
+#   published by the Free Software Foundation, either version 3 of the        #
+#   License, or (at your option) any later version.                           #
+#                                                                             #
+#   This program is distributed in the hope that it will be useful,           #
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of            #
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the             #
+#   GNU Affero General Public License for more details.                       #
+#                                                                             #
+#   You should have received a copy of the GNU Affero General Public License  #
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.     #
+#                                                                             #
+###############################################################################
+
+from . import stock  # noqa

=== added file 'mrp_split_one/__openerp__.py'
--- mrp_split_one/__openerp__.py	1970-01-01 00:00:00 +0000
+++ mrp_split_one/__openerp__.py	2014-01-17 11:03:38 +0000
@@ -0,0 +1,41 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#                                                                             #
+#   Author: Leonardo Pistone <[e-mail]>                #
+#   Copyright 2013 Camptocamp SA                                              #
+#                                                                             #
+#   This program is free software: you can redistribute it and/or modify      #
+#   it under the terms of the GNU Affero General Public License as            #
+#   published by the Free Software Foundation, either version 3 of the        #
+#   License, or (at your option) any later version.                           #
+#                                                                             #
+#   This program is distributed in the hope that it will be useful,           #
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of            #
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the             #
+#   GNU Affero General Public License for more details.                       #
+#                                                                             #
+#   You should have received a copy of the GNU Affero General Public License  #
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.     #
+#                                                                             #
+###############################################################################
+
+{'name': 'MRP Split One',
+ 'version': '0.1',
+ 'category': 'Generic Modules/Others',
+ 'license': 'AGPL-3',
+ 'description': """MRP Split one unit in a production order.
+
+This module adds a button in each line of the Products to Finish and Finished
+Products to directly split one unit of the product in a separate line.
+After the split the page needs to be reloaded because of the bug lp:1083253.
+""",
+ 'complexity': 'easy',
+ 'author': 'Camptocamp',
+ 'website': 'http://www.camptocamp.com/',
+ 'depends': ['mrp'],
+ 'init_xml': [],
+ 'update_xml': ['mrp_view.xml'],
+ 'demo_xml': [],
+ 'installable': True,
+ 'active': False,
+ }

=== added directory 'mrp_split_one/i18n'
=== added file 'mrp_split_one/i18n/fr.po'
--- mrp_split_one/i18n/fr.po	1970-01-01 00:00:00 +0000
+++ mrp_split_one/i18n/fr.po	2014-01-17 11:03:38 +0000
@@ -0,0 +1,54 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* mrp_split_one
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 6.1\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2013-12-16 15:40+0000\n"
+"PO-Revision-Date: 2013-12-16 15:40+0000\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: mrp_split_one
+#: model:ir.model,name:mrp_split_one.model_stock_move
+msgid "Stock Move"
+msgstr "Mouvement de stock"
+
+#. module: mrp_split_one
+#: code:addons/mrp_split_one/stock.py:36
+#, python-format
+msgid "Quantity needs to be more that 1."
+msgstr "La quantité doit être plus grande que 1."
+
+#. module: mrp_split_one
+#: constraint:stock.move:0
+msgid "You can not move products from or to a location of the type view."
+msgstr "Vous ne pouvez pas déplacer un produit vers ou depuis un emplacement de type vue."
+
+#. module: mrp_split_one
+#: constraint:stock.move:0
+msgid "You must assign a production lot for this product"
+msgstr "Vous devez affecter un lot de fabrication pour ce produit."
+
+#. module: mrp_split_one
+#: constraint:stock.move:0
+msgid "You try to assign a lot which is not from the same product"
+msgstr "Vous essayez d'affecter un lot qui n'est pas pour ce produit."
+
+#. module: mrp_split_one
+#: view:mrp.production:0
+msgid "Split One"
+msgstr "Split One"
+
+#. module: mrp_split_one
+#: code:addons/mrp_split_one/stock.py:35
+#, python-format
+msgid "Error"
+msgstr "Erreur"
+

=== added file 'mrp_split_one/i18n/mrp_split_one.pot'
--- mrp_split_one/i18n/mrp_split_one.pot	1970-01-01 00:00:00 +0000
+++ mrp_split_one/i18n/mrp_split_one.pot	2014-01-17 11:03:38 +0000
@@ -0,0 +1,54 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* mrp_split_one
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 6.1\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2013-12-16 15:36+0000\n"
+"PO-Revision-Date: 2013-12-16 15:36+0000\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: mrp_split_one
+#: model:ir.model,name:mrp_split_one.model_stock_move
+msgid "Stock Move"
+msgstr ""
+
+#. module: mrp_split_one
+#: code:addons/mrp_split_one/stock.py:36
+#, python-format
+msgid "Quantity needs to be more that 1."
+msgstr ""
+
+#. module: mrp_split_one
+#: constraint:stock.move:0
+msgid "You can not move products from or to a location of the type view."
+msgstr ""
+
+#. module: mrp_split_one
+#: constraint:stock.move:0
+msgid "You must assign a production lot for this product"
+msgstr ""
+
+#. module: mrp_split_one
+#: constraint:stock.move:0
+msgid "You try to assign a lot which is not from the same product"
+msgstr ""
+
+#. module: mrp_split_one
+#: view:mrp.production:0
+msgid "Split One"
+msgstr ""
+
+#. module: mrp_split_one
+#: code:addons/mrp_split_one/stock.py:35
+#, python-format
+msgid "Error"
+msgstr ""
+

=== added file 'mrp_split_one/mrp_view.xml'
--- mrp_split_one/mrp_view.xml	1970-01-01 00:00:00 +0000
+++ mrp_split_one/mrp_view.xml	2014-01-17 11:03:38 +0000
@@ -0,0 +1,21 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+    <data>
+
+        <record id="mrp_production_form_lot_attribute_view" model="ir.ui.view">
+            <field name="name">mrp.production.lot.attribute.form</field>
+            <field name="model">mrp.production</field>
+            <field name="inherit_id" ref="mrp.mrp_production_form_view"/>
+            <field name="type">form</field>
+            <field name="arch" type="xml">
+                <xpath expr="/form/notebook/page[@string='Finished Products']/field[@name='move_created_ids']/tree/button[@string='Scrap Products']" position="after">
+                    <button name="split_one_to_finish" string="Split One" type="object" icon="gtk-jump-to"/>
+                </xpath>
+                <xpath expr="/form/notebook/page[@string='Finished Products']/field[@name='move_created_ids2']/tree/button[@string='Scrap Products']" position="after">
+                    <button name="split_one_finished" string="Split One" type="object" icon="gtk-jump-to"/>
+                </xpath>
+            </field>
+        </record>
+
+    </data>
+</openerp>

=== added file 'mrp_split_one/stock.py'
--- mrp_split_one/stock.py	1970-01-01 00:00:00 +0000
+++ mrp_split_one/stock.py	2014-01-17 11:03:38 +0000
@@ -0,0 +1,79 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#                                                                             #
+#   Author: Leonardo Pistone <[e-mail]>                #
+#   Copyright 2013 Camptocamp SA                                              #
+#                                                                             #
+#   This program is free software: you can redistribute it and/or modify      #
+#   it under the terms of the GNU Affero General Public License as            #
+#   published by the Free Software Foundation, either version 3 of the        #
+#   License, or (at your option) any later version.                           #
+#                                                                             #
+#   This program is distributed in the hope that it will be useful,           #
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of            #
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the             #
+#   GNU Affero General Public License for more details.                       #
+#                                                                             #
+#   You should have received a copy of the GNU Affero General Public License  #
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.     #
+#                                                                             #
+###############################################################################
+"""MRP Split one unit in a production order."""
+from openerp.osv import orm
+from tools.translate import _
+
+
+class stock_move(orm.Model):
+
+    """We add to the stock.move methods for the split one button."""
+
+    _inherit = 'stock.move'
+
+    def split_one(self, cr, uid, ids, context=None):
+        """Split the current move creating one with quantity one.
+
+        Return action.
+
+        """
+
+        if context is None:
+            context = {}
+
+        for move in self.browse(cr, uid, ids, context=context):
+            if move.product_qty <= 1.0:
+                raise orm.except_orm(
+                    _('Error'),
+                    _('Quantity needs to be more that 1.')
+                )
+
+            self.write(cr, uid, move.id, {
+                'product_qty': move.product_qty - 1.0,
+                'product_uos_qty': move.product_uos_qty - 1.0,
+            }, context=context)
+            default_val = {
+                'product_qty': 1.0,
+                'product_uos_qty': 1.0,
+                'state': move.state,
+                'prodlot_id': False,
+            }
+            #create the new move
+            self.copy(cr, uid, move.id, default_val, context=context)
+
+        # poor man's refresh
+        return {
+            'view_type': 'form',
+            'view_mode': 'form',
+            'res_model': 'mrp.production',
+            'type': 'ir.actions.act_window',
+            'target': 'current',
+            'context': context,
+            'res_id': move.production_id.id,
+        }
+
+    def split_one_finished(self, cr, uid, ids, context=None):
+        """Split one unit from the finished products. Return action."""
+        return self.split_one(cr, uid, ids, context=context)
+
+    def split_one_to_finish(self, cr, uid, ids, context=None):
+        """Split one unit from the products to finish. Return action."""
+        return self.split_one(cr, uid, ids, context=context)