Merge lp:~camptocamp/openerp-humanitarian-ngo/change-button-to-send-email-in-draftpo into lp:openerp-humanitarian-ngo/purchase-wkfl

[Romain Deheele - Camptocamp]

Hi,

It changes the button visible in draftpo state.
At this state, users prefer to have the possibility to send email with RFQ template instead of PO template (the purchase is still not approved)

Regards,

Romain

[Leonardo Pistone (lepistone)]

Romain,

it looks like the two button have the same string. Maybe we could change a bit one of the two?

thanks!

review: Needs Fixing (code review)

[lp:~camptocamp/openerp-humanitarian-ngo/change-button-to-send-email-in-draftpo]

79. By Romain Deheele - Camptocamp on 2014-02-21

[FIX] change button name with "Send Draft PO by Email" to avoid confusion

[Romain Deheele - Camptocamp (romaindeheele)]

Good idea,
I've just changed it to avoid confusion.

Romain

[Leonardo Pistone (lepistone)]

thanks!

review: Approve (code review)

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

LGTM

Cheers

review: Approve

=== modified file 'purchase_extended/view/purchase_order.xml'
--- purchase_extended/view/purchase_order.xml	2014-02-10 13:16:22 +0000
+++ purchase_extended/view/purchase_order.xml	2014-02-21 15:43:37 +0000
@@ -25,8 +25,8 @@
                     <attribute name="states">cancel,draftpo</attribute>
                     <attribute name="string">Reset to Draft RFQ</attribute>
                 </xpath>
-                <xpath expr="//button[@string='Send PO by Email']" position="attributes">
-                    <attribute name="states">draftpo,approved</attribute>
+                <xpath expr="//button[@string='Send PO by Email']" position="after">
+                    <button name="wkf_send_rfq" states="draftpo" string="Send Draft PO by Email" type="object" context="{'send_rfq':True}"/>
                 </xpath>
                 <xpath expr="//button[@name='bid_received']" position="attributes">
                     <attribute name="string">Bid Encoded</attribute>