Code review comment for lp:~camptocamp/openerp-fiscal-rules/7.0-wrong-onchange-1255918

Revision history for this message
Raphaƫl Valyi - http://www.akretion.com (rvalyi) wrote :

Just as a post-mortem comment for documentation:

the dead code that Gueween was telling was never reached, was actually reached in our specific case in the Brazilian Localization because we were overriding the context in such a way in the view and we had no more shop_id... (we overrided the context view attribute to pass extra params but missed shop_id)

I really believe the usage of web_context_tunnel instead https://code.launchpad.net/~akretion-team/server-env-tools/web-context-tunnel/+merge/198599 will allow to inject extra parameters in the context (instead of making son_change signatures incompatibles) without risking to just bypass the original context as it was occurring in this specific case and made us miss the bug.

Regards.

« Back to merge proposal