Code review comment for lp:~camptocamp/openerp-fiscal-rules/7.0-wrong-onchange-1255918
Revision history for this message
| Raphaël Valyi - http://www.akretion.com (rvalyi) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
Hello Guewen,
yes, you are right, I'll double check, but it rather look this code wasn't reached at all and that the fiscal rule is applied as expected just because onchange_address_id was called later in the chain (with an annoying signature change in our localization this time BTW)...
Eventually, what we could do is: clean the base code just as you suggest. And in our localization, we do the nasty context to kwargs transfer. We can actually do it without changing the method signature (the extra args will be transferred at any point in the super chain).
Let me do some testing and then I confirm we can still live with that and you do the whole merge.