Merge lp:~camptocamp/openerp-fiscal-rules/7.0-onchange_shop_id-1277125 into lp:openerp-fiscal-rules
Proposed by
Guewen Baconnier @ Camptocamp
Status: | Merged |
---|---|
Approved by: | Yannick Vaucher @ Camptocamp |
Approved revision: | 68 |
Merged at revision: | 69 |
Proposed branch: | lp:~camptocamp/openerp-fiscal-rules/7.0-onchange_shop_id-1277125 |
Merge into: | lp:openerp-fiscal-rules |
Diff against target: |
12 lines (+2/-1) 1 file modified
account_fiscal_position_rule_sale/sale.py (+2/-1) |
To merge this branch: | bzr merge lp:~camptocamp/openerp-fiscal-rules/7.0-onchange_shop_id-1277125 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Pedro Manuel Baeza | code review | Approve | |
Leonardo Pistone | code review | Approve | |
Raphaël Valyi - http://www.akretion.com | Approve | ||
Review via email: mp+205190@code.launchpad.net |
Commit message
[FIX] onchange_shop_id should call super to initialize all the fields properly
Description of the change
Fixes lp:1277125
To post a comment you must log in.
OK, nice catch.
BTW, instead of changing the signature of the onchange_shop_id, in the future (v8?) I suggest we use web_context_tunnel here. In any case the sale.order shop_id is t be replaced by the sale team and the warehouse in v8, but you get the idea.