Merge lp:~camptocamp/openerp-fiscal-rules/7.0-onchange_shop_id-1277125 into lp:openerp-fiscal-rules

Proposed by Guewen Baconnier @ Camptocamp
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 68
Merged at revision: 69
Proposed branch: lp:~camptocamp/openerp-fiscal-rules/7.0-onchange_shop_id-1277125
Merge into: lp:openerp-fiscal-rules
Diff against target: 12 lines (+2/-1)
1 file modified
account_fiscal_position_rule_sale/sale.py (+2/-1)
To merge this branch: bzr merge lp:~camptocamp/openerp-fiscal-rules/7.0-onchange_shop_id-1277125
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza code review Approve
Leonardo Pistone code review Approve
Raphaël Valyi - http://www.akretion.com Approve
Review via email: mp+205190@code.launchpad.net

Commit message

[FIX] onchange_shop_id should call super to initialize all the fields properly

Description of the change

To post a comment you must log in.
Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :

OK, nice catch.

BTW, instead of changing the signature of the onchange_shop_id, in the future (v8?) I suggest we use web_context_tunnel here. In any case the sale.order shop_id is t be replaced by the sale team and the warehouse in v8, but you get the idea.

review: Approve
Revision history for this message
Leonardo Pistone (lepistone) wrote :

ok!

review: Approve (code review)
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM

review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_fiscal_position_rule_sale/sale.py'
2--- account_fiscal_position_rule_sale/sale.py 2013-12-16 15:22:28 +0000
3+++ account_fiscal_position_rule_sale/sale.py 2014-02-06 15:24:08 +0000
4@@ -89,7 +89,8 @@
5 if not context:
6 context = {}
7
8- result = {'value': {}}
9+ result = super(sale_order, self).onchange_shop_id(
10+ cr, uid, ids, shop_id, context=context)
11 if not shop_id or not partner_id:
12 return result
13

Subscribers

People subscribed via source and target branches