> I tried to give a look to the ORM to see if it clearly treats string field
> contents as unicode, as opposed to utf-8 bytestrings, but that is convoluted
> to say the least (it uses ustr() from server/openerp/loglevels.py).
>
> Picked data is indeed binary, so I agree, good idea. And indeed it is a good
> idea to test it
>
> I have a little doubt left: this line from job.py:
>
> func = _unpickle(str(stored.func)) # openerp stores them as unicode...
>
> Is "str" still necessary?
Good catch!
>
> Moreover, maybe we could add in the test a bytestring parameter with accents.
> I tried to give a look to the ORM to see if it clearly treats string field openerp/ loglevels. py). str(stored. func)) # openerp stores them as unicode...
> contents as unicode, as opposed to utf-8 bytestrings, but that is convoluted
> to say the least (it uses ustr() from server/
>
> Picked data is indeed binary, so I agree, good idea. And indeed it is a good
> idea to test it
>
> I have a little doubt left: this line from job.py:
>
> func = _unpickle(
>
> Is "str" still necessary?
Good catch!
>
> Moreover, maybe we could add in the test a bytestring parameter with accents.
You are right, added.
>
> Thanks!
Thanks for your review