Code review comment for lp:~camptocamp/openerp-connector/7.0-unicode-pickled-1288187

Revision history for this message
Leonardo Pistone (lepistone) wrote :

I tried to give a look to the ORM to see if it clearly treats string field contents as unicode, as opposed to utf-8 bytestrings, but that is convoluted to say the least (it uses ustr() from server/openerp/loglevels.py).

Picked data is indeed binary, so I agree, good idea. And indeed it is a good idea to test it

I have a little doubt left: this line from job.py:

    func = _unpickle(str(stored.func)) # openerp stores them as unicode...

Is "str" still necessary?

Moreover, maybe we could add in the test a bytestring parameter with accents.

Thanks!

review: Needs Information (code review)

« Back to merge proposal