Merge lp:~camptocamp/openerp-connector-magento/7.0-fix_1276645-afe into lp:~openerp-connector-core-editors/openerp-connector-magento/7.0

[Alexandre Fayolle - camptocamp]

fix a crash when importing customers

if None is passed to magento_api.info for the attributes, then a very minimal list of attributes is returned. The argument must be omitted completely to get a standard list of attributes.

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

tested on my customer's dev instance, works well.

[lp:~camptocamp/openerp-connector-magento/7.0-fix_1276645-afe]

958. By Alexandre Fayolle - camptocamp on 2014-02-06

[IMP] added comment to explain the fix

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Magento is supposed to handle correctly the Null value. The behavior you observe is probably due to an incompatibility between Magento 1.7 and PHP 5.4 (lp:1210775).

My only doubt here is that the magento library does the same thing that what you propose [0], so the authors could have a reason to do so and on the other hand, the other (similar) calls do not prevent to send Null [1] (and it becomes impossible when several positional arguments may be Null).

I will merge this one to be consistent with what the magento lib does.

Thanks for the report and proposal!

[0] https://github.com/openlabs/magento/blob/develop/magento/customer.py#L50
[1] https://github.com/openlabs/magento/blob/develop/magento/catalog.py#L56

review: Approve

[Romain Deheele - Camptocamp (romaindeheele)]

I have seen that with my own eyes.
LGTM,

Romain

review: Approve (code review)

=== modified file 'magentoerpconnect/unit/backend_adapter.py'
--- magentoerpconnect/unit/backend_adapter.py	2013-06-26 06:36:58 +0000
+++ magentoerpconnect/unit/backend_adapter.py	2014-02-06 07:17:50 +0000
@@ -168,8 +168,12 @@
 
         :rtype: dict
         """
+        arguments = [int(id)]
+        if attributes: # don't pass a None in the attributes, otherwise you
+                       # only get a default almost empty list of attributes.
+            arguments.append(attributes)
         return self._call('%s.info' % self._magento_model,
-                          [int(id), attributes])
+                          arguments)
 
     def search_read(self, filters=None):
         """ Search records according to some criterias