Merge lp:~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh into lp:ocb-web

Proposed by Alexandre Fayolle - camptocamp
Status: Merged
Approved by: Holger Brunn (Therp)
Approved revision: 4187
Merged at revision: 4193
Proposed branch: lp:~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh
Merge into: lp:ocb-web
Diff against target: 12 lines (+0/-2)
1 file modified
addons/web_kanban/static/src/js/kanban.js (+0/-2)
To merge this branch: bzr merge lp:~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) code review Approve
Leonardo Pistone code review Approve
Pedro Manuel Baeza code review Approve
Review via email: mp+216664@code.launchpad.net

Description of the change

Fixed the issue of kanban not shows exception message, instead it shows static message, rpc fail already shows error popup so there is not need of special alert.

Demo: Override write for any object for which kanban view is developed, raise exception with your message from write, move kanban box from one state to another so that exception raised.

Result: Alert box instead of error popup.
Expected: error popup should come with defined message.

Port of https://code.launchpad.net/~openerp-dev/openerp-web/7.0-opw-595981-msh/+merge/177740 to OCB

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM.

Regards.

review: Approve (code review)
Revision history for this message
Leonardo Pistone (lepistone) wrote :

thanks

review: Approve (code review)
Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web_kanban/static/src/js/kanban.js'
2--- addons/web_kanban/static/src/js/kanban.js 2014-01-17 10:19:43 +0000
3+++ addons/web_kanban/static/src/js/kanban.js 2014-04-22 06:57:24 +0000
4@@ -424,8 +424,6 @@
5 record.do_reload();
6 new_group.do_save_sequences();
7 }).fail(function(error, evt) {
8- evt.preventDefault();
9- alert(_t("An error has occured while moving the record to this group: ") + data.fault_code);
10 self.do_reload(); // TODO: use draggable + sortable in order to cancel the dragging when the rcp fails
11 });
12 }

Subscribers

People subscribed via source and target branches