Merge lp:~camptocamp/ocb-addons/7.0-send-message-slow-1311087 into lp:ocb-addons

Proposed by Guewen Baconnier @ Camptocamp
Status: Rejected
Rejected by: Holger Brunn (Therp)
Proposed branch: lp:~camptocamp/ocb-addons/7.0-send-message-slow-1311087
Merge into: lp:ocb-addons
Diff against target: 17 lines (+4/-2)
1 file modified
mail/mail_message.py (+4/-2)
To merge this branch: bzr merge lp:~camptocamp/ocb-addons/7.0-send-message-slow-1311087
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) Disapprove
Laurent Mignon (Acsone) (community) code review Approve
Pedro Manuel Baeza code review Approve
Review via email: mp+222765@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM.

Regards.

review: Approve (code review)
Revision history for this message
Laurent Mignon (Acsone) (lmi) wrote :

LGTM.

Regards.

lmi

review: Approve (code review)
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid.

(I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad)

review: Disapprove

Unmerged revisions

10205. By Ravi Gohil (OpenERP)

[FIX] mail: speed improvement in the process of sending an email through 'Send by email' option, fix backported from trunk rev: 9345(issue reproduced with client's db which has 6 million records for 'subtype_ids' o2m table). (Maintenance Case: 606994)

10204. By Loïc Bellier - Numérigraphe

[IMP]: Due to huge memory usage on browse, slice move_ids to list of 10000 elements maximum on fill_inventory.

10203. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

10202. By Stefan Rijnhart (Opener)

[FIX] project_timesheet: Prevent python term 'False' to show up in timesheet lines generated from task work

10201. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

10200. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

10199. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

10198. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

10197. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

10196. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'mail/mail_message.py'
2--- mail/mail_message.py 2014-03-10 08:54:20 +0000
3+++ mail/mail_message.py 2014-06-11 09:26:30 +0000
4@@ -881,9 +881,11 @@
5 fol_ids = fol_obj.search(cr, SUPERUSER_ID, [
6 ('res_model', '=', message.model),
7 ('res_id', '=', message.res_id),
8- ('subtype_ids', 'in', message.subtype_id.id)
9 ], context=context)
10- partners_to_notify |= set(fo.partner_id for fo in fol_obj.browse(cr, SUPERUSER_ID, fol_ids, context=context))
11+ partners_to_notify |= set(
12+ fo.partner_id for fo in fol_obj.browse(cr, SUPERUSER_ID, fol_ids, context=context)
13+ if message.subtype_id.id in [st.id for st in fo.subtype_ids]
14+ )
15 # remove me from notified partners, unless the message is written on my own wall
16 if message.author_id and message.model == "res.partner" and message.res_id == message.author_id.id:
17 partners_to_notify |= set([message.author_id])