Merge lp:~camptocamp/ocb-addons/7.0-fix-1319095 into lp:ocb-addons
Proposed by
Yannick Vaucher @ Camptocamp
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Leonardo Pistone | ||||||||
Approved revision: | no longer in the source branch. | ||||||||
Merged at revision: | 10208 | ||||||||
Proposed branch: | lp:~camptocamp/ocb-addons/7.0-fix-1319095 | ||||||||
Merge into: | lp:ocb-addons | ||||||||
Diff against target: |
74 lines (+15/-25) 1 file modified
report_webkit/webkit_report.py (+15/-25) |
||||||||
To merge this branch: | bzr merge lp:~camptocamp/ocb-addons/7.0-fix-1319095 | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Pedro Manuel Baeza | code review | Approve | |
Alexandre Fayolle - camptocamp | code review, no test | Approve | |
Nicolas Bessi - Camptocamp (community) | no test, code review | Approve | |
Florent | Pending | ||
Review via email:
|
Description of the change
Use NamedTemporaryFile instead of file and of deprecated mktemp. That way we ensure 2 files created at the exact same time will have a unique name
Another hot fix from Florent was made here https:/
I believe this one is a bit cleaner as it refactor a bit the code. However it doesn't keep timestamp in file name. But do we need timestamp in file name ?
If so I can still add it in prefix or suffix.
To post a comment you must log in.
Thanks for the fix.
LGTM
This patch will not be backportable as is to version 6.1, 6.0 as it is not Python 2.5 compliant
Regards
Nicolas