Merge lp:~camptocamp/ocb-addons/7.0-fix-1189524 into lp:ocb-addons

[Yannick Vaucher @ Camptocamp]

[FIX] project - do not copy task_ids of res.partner

For performances and to avoid errors with timesheet_task module on copy.

[Stefan Rijnhart (Opener) (stefan-opener)]

l.13: even if the order of named arguments in OpenERP is conventionally very regular, you might still want to refer to the arguments' names in the call to super, so as to allow for an unexpected API change.

    super(res_partner, self).copy(cr, uid, record_id, default=default, context=context)

instead of

    super(res_partner, self).copy(cr, uid, record_id, default, context)

review: Needs Fixing

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Thanks for the review, I just added the argument names

[Stefan Rijnhart (Opener) (stefan-opener)]

Thanks!

review: Approve

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

By the way I wonder if this should be done for contract_ids for performances in account/account_analytic_line.py

At least this one doesn't block duplication of partner but I don't see why we would like to copy contracts while duplicating a partner.

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Just did the same change as in MP for official (which is now approved)

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Merged into lp:openobject-addons/7.0 at revision 9226

Not needed anymore

Please Reject it

review: Disapprove

[Stefan Rijnhart (Opener) (stefan-opener)]

Rejected as per last comment.

=== modified file 'project/res_partner.py'
--- project/res_partner.py	2012-12-06 14:56:32 +0000
+++ project/res_partner.py	2013-06-12 11:52:40 +0000
@@ -29,6 +29,14 @@
         'task_ids': fields.one2many('project.task', 'partner_id', 'Tasks'),
     }
 
+    def copy(self, cr, uid, record_id, default=None, context=None):
+        if default is None:
+            default = {}
+
+        default['task_ids'] = []
+        return super(res_partner, self).copy(
+                cr, uid, record_id, default=default, context=context)
+
 res_partner()