Magento OpenERP Connector

Merge lp:~camptocamp/magentoerpconnect/oerp6.1-oldstable-fix-cron-method-2013-03-13 into lp:magentoerpconnect/oerp6.1-oldstable

  1. oerp6.1-oldstable-fix-cron-method-2013-03-13
  2. Merge into trunk_version
Proposed by Yannick Vaucher @ Camptocamp
Status: Merged
Merged at revision: 672
Proposed branch: lp:~camptocamp/magentoerpconnect/oerp6.1-oldstable-fix-cron-method-2013-03-13
Merge into: lp:magentoerpconnect/oerp6.1-oldstable
Diff against target: 12 lines (+1/-1)
1 file modified
magentoerpconnect/sale.py (+1/-1)
To merge this branch: bzr merge lp:~camptocamp/magentoerpconnect/oerp6.1-oldstable-fix-cron-method-2013-03-13
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp code review, no test Approve
Review via email: mp+153194@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Variable ids renamed to variable group_ids

Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

LGTM

review: Approve (code review, no test)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'magentoerpconnect/sale.py'
2--- magentoerpconnect/sale.py 2013-02-14 12:59:51 +0000
3+++ magentoerpconnect/sale.py 2013-03-13 16:55:26 +0000
4@@ -168,7 +168,7 @@
5 group_ids = self.search(cr, uid, [], context=context)
6
7 if group_ids:
8- shop_groups = self.browse(cr, uid, ids, context=context)
9+ shop_groups = self.browse(cr, uid, group_ids, context=context)
10
11 for group in shop_groups:
12 self._import_partners(cr, uid, group, context=context)