Merge lp:~camptocamp/magentoerpconnect/magentoerpconnect_generic_bug_497216 into lp:~magentoerpconnect-core-editors/magentoerpconnect/magentoerpconnect_generic

Proposed by Nicolas Bessi - Camptocamp
Status: Needs review
Proposed branch: lp:~camptocamp/magentoerpconnect/magentoerpconnect_generic_bug_497216
Merge into: lp:~magentoerpconnect-core-editors/magentoerpconnect/magentoerpconnect_generic
Diff against target: 12 lines (+1/-1)
1 file modified (+1/-1)
To merge this branch: bzr merge lp:~camptocamp/magentoerpconnect/magentoerpconnect_generic_bug_497216
Reviewer Review Type Date Requested Status
Sharoon Thomas Approve
Review via email:

Commit message

Fix of bug 497216

Description of the change

OK Live and learn, the bug fix is really small, but I had to understand the whole process in order to fix it.

Thanks to everybody for the help.
I hope this one will be good.

Regards Nicolas

To post a comment you must log in.
Revision history for this message
Sharoon Thomas (sharoonthomas) wrote :

The fix looks trivial

(I have not tested it though its the same fix i suggested.)

I think we should wait for two more approvals (Functional & Technical) before merging.

I assume that Your merge proposal can be considered the first functional approval.
So requesting one more approvals before we merge this.

review: Approve
Revision history for this message
Sharoon Thomas (sharoonthomas) wrote :

I have tested this both functionally & technically.

Hence i approve this merge.

Unmerged revisions

296. By Nicolas Bessi - Camptocamp on 2010-04-01

Fix of bug 497216

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file ''
2--- 2010-03-26 18:17:43 +0000
3+++ 2010-04-01 08:17:16 +0000
4@@ -84,7 +84,7 @@
5 #Get all attribute set ids to get all attributes in one go
6 all_attr_set_ids = self.pool.get('magerp.product_attribute_set').get_all_mage_ids(cr, uid, [],
7 #Call magento for all attributes
8- mage_inp ='ol_catalog_product_attribute.list', all_attr_set_ids) #Get the tree
9+ mage_inp ='ol_catalog_product_attribute.list', [all_attr_set_ids]) #Get the tree
10 #self.pool.get('magerp.product_attributes').sync_import(cr, uid, mage_inp,, DEBUG) #Last argument is extra mage2oe filter as same attribute ids
11 self.pool.get('magerp.product_attributes').ext_import(cr, uid, mage_inp,, defaults={'referential_id'}, context={'referential_id'})
12 #Relate attribute sets & attributes


People subscribed via source and target branches

to status/vote changes: