Merge lp:~camptocamp/e-commerce-addons/7.0-sale_payment_method-incompatible-args into lp:~extra-addons-commiter/e-commerce-addons/7.0

[Guewen Baconnier @ Camptocamp]

The 'description' argument has been added [0] recently in the method and is optional in the body of the method (fallback to self._get_payment_move_name when not defined).
Thus, I propose to make it optional, avoiding errors in code using the previous version of the signature (without description).

The method "automatic_payment" itself in this module is broken because it does not give a description.

[0] <email address hidden>

[Leonardo Pistone (lepistone)]

LGTM

review: Approve (code review)

[Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount)]

LGTM

review: Approve (no test, code review)

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

LGTM

review: Approve (code review, no tests)

=== modified file 'sale_payment_method/sale.py'
--- sale_payment_method/sale.py	2013-09-01 16:28:01 +0000
+++ sale_payment_method/sale.py	2014-01-14 12:57:29 +0000
@@ -149,7 +149,7 @@
         self._add_payment(cr, uid, sale, journal, amount, date, description, context=context)
         return True
 
-    def _add_payment(self, cr, uid, sale, journal, amount, date, description, context=None):
+    def _add_payment(self, cr, uid, sale, journal, amount, date, description=None, context=None):
         """ Generate move lines entries to pay the sale order. """
         move_obj = self.pool.get('account.move')
         period_obj = self.pool.get('account.period')