Merge lp:~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation into lp:~stock-logistic-core-editors/carriers-deliveries/7.0
Status: | Needs review |
---|---|
Proposed branch: | lp:~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation |
Merge into: | lp:~stock-logistic-core-editors/carriers-deliveries/7.0 |
Prerequisite: | lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_dispatch-output-file-yvr |
Diff against target: |
230 lines (+148/-27) 2 files modified
delivery_carrier_label_dispatch/__openerp__.py (+14/-1) delivery_carrier_label_dispatch/wizard/generate_labels.py (+134/-26) |
To merge this branch: | bzr merge lp:~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Nicolas Bessi - Camptocamp (community) | Approve | ||
Stock and Logistic Core Editors | Pending | ||
Review via email: mp+215184@code.launchpad.net |
Commit message
delivery_
Also improve exception feed back. And thus exception are non blocking for all label generation. You will only have to relaunch generation for failed ones.
Unmerged revisions
- 47. By Yannick Vaucher @ Camptocamp
-
Specify Exception class to ensure catching right exceptions and avoid catching SystemExit and KeyboardInterupt exceptions
- 46. By Yannick Vaucher @ Camptocamp
-
rewrite exception handling for cursor and orm exceptions on generate_labels
- 45. By Yannick Vaucher @ Camptocamp
-
[PEP8]
- 44. By Yannick Vaucher @ Camptocamp
-
remove unused import
- 43. By Yannick Vaucher @ Camptocamp
-
Fix rst title in manifest
- 42. By Yannick Vaucher @ Camptocamp
-
removed conflict garbage
- 41. By Yannick Vaucher @ Camptocamp
-
delivery_
carrier_ label_dispatch - Improve efficiency of label generation by threading it. For instance for postlogistics, using serialized calls to the SOAP web service is a really slow as it would wait for a response before sending the next request. - 40. By Yannick Vaucher @ Camptocamp
-
merge lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_dispatch-output-file-yvr
Hello,
Thank for the patch
Small PEP8 in manifest also noticed that
the title underline is not correct
[Link module] Carrier labels - Picking dispatch ======= ======= ======= ==
=======
It should go to the end of previous line
sys is imported but not used
remark
q_except can be a simpler data cohntainer like a list has they are thread safe.
the nested try catch structure here is strange
try:
picking_ out_obj. generate_ labels(
thread_ cr, uid, [picking.id],
tracking_ ids=tracking_ ids,
context= context)
picking_ name = _('Picking: %s') % picking.name
pack_ num = _('Pack: %s') % pack.name if pack else ''
raise orm.except_orm(
e. name,
_ ('%s %s - %s') % (picking_name, pack_num, e.value)) ...
try:
except orm.except_orm as e:
# add information on picking and pack in the exception