Merge lp:~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_label-change-carrier into lp:~stock-logistic-core-editors/carriers-deliveries/7.0
Proposed by
Guewen Baconnier @ Camptocamp
Status: | Merged |
---|---|
Approved by: | Yannick Vaucher @ Camptocamp |
Approved revision: | 11 |
Merged at revision: | 27 |
Proposed branch: | lp:~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_label-change-carrier |
Merge into: | lp:~stock-logistic-core-editors/carriers-deliveries/7.0 |
Diff against target: |
122 lines (+83/-11) 1 file modified
base_delivery_carrier_label/stock.py (+83/-11) |
To merge this branch: | bzr merge lp:~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_label-change-carrier |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Nicolas Bessi - Camptocamp (community) | no test, code review | Approve | |
Yannick Vaucher @ Camptocamp | code review, no tests | Approve | |
Review via email: mp+208367@code.launchpad.net |
Commit message
Set the default options of the delivery method when it is changed and the options are not set (typically a write from the code or a mass update)
Description of the change
The options are strongly related to the selected carrier. A selected option could have no reason to be on a carrier or another option could be required.
When the carrier is modified by a user from the views, the onchange set the correct options, that the user might modify.
However, when the carrier is modified directly from a write / create (and the call does not set the according options), we must ensure that the correct options for the carrier are set.
To post a comment you must log in.
LGTM