Merge lp:~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde into lp:~stock-logistic-core-editors/carriers-deliveries/6.1

Proposed by Romain Deheele - Camptocamp
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 7
Merged at revision: 7
Proposed branch: lp:~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde
Merge into: lp:~stock-logistic-core-editors/carriers-deliveries/6.1
Diff against target: 21 lines (+2/-2)
1 file modified
base_delivery_carrier_files/generator/generic_generator.py (+2/-2)
To merge this branch: bzr merge lp:~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde
Reviewer Review Type Date Requested Status
Leonardo Pistone code review Approve
Yannick Vaucher @ Camptocamp Approve
Pedro Manuel Baeza code review Approve
Review via email: mp+210772@code.launchpad.net

Description of the change

Hi,

It fixes https://bugs.launchpad.net/carriers-deliveries/+bug/1291916
Some changes to have a correct fields mapping.

Regards,

Romain

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM

review: Approve (code review)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) :
review: Approve
Revision history for this message
Leonardo Pistone (lepistone) wrote :

ok

review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'base_delivery_carrier_files/generator/generic_generator.py'
2--- base_delivery_carrier_files/generator/generic_generator.py 2012-04-02 06:59:30 +0000
3+++ base_delivery_carrier_files/generator/generic_generator.py 2014-03-13 11:17:26 +0000
4@@ -38,7 +38,7 @@
5 'country_code',
6 'phone',
7 'fax',
8- 'mail'
9+ 'mail',
10 'delivery_name',
11 'weight')
12
13@@ -71,7 +71,7 @@
14 line.city = address.city
15 line.state = (picking.address_id.state_id and
16 picking.address_id.state_id.name)
17- line.country = address.country_id and address.country_id.code
18+ line.country_code = address.country_id and address.country_id.code
19 line.phone = address.phone or address.mobile
20 line.mail = address.email
21 line.fax = address.fax

Subscribers

People subscribed via source and target branches