Merge lp:~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde into lp:~stock-logistic-core-editors/carriers-deliveries/6.1
Proposed by
Romain Deheele - Camptocamp
Status: | Merged |
---|---|
Merged at revision: | 8 |
Proposed branch: | lp:~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde |
Merge into: | lp:~stock-logistic-core-editors/carriers-deliveries/6.1 |
Diff against target: |
27 lines (+4/-4) 1 file modified
base_delivery_carrier_files_document/carrier_file.py (+4/-4) |
To merge this branch: | bzr merge lp:~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Leonardo Pistone | code review | Approve | |
Alexandre Fayolle - camptocamp | code review, no test | Approve | |
Review via email: mp+213883@code.launchpad.net |
Description of the change
Hi,
In base_delivery_
by coincidence, the class and a frequently used parameter are both named "carrier_file".
in l.55, the super method will take carrier_file parameter while it needs carrier_file, the class name.
It causes logically the error : TypeError: 'must be type, not browse_record'
Great catch from Leonardo Pistone, thank you.
Regards,
Romain
To post a comment you must log in.
LGTM