Merge lp:~camptocamp/c2c-web-addons/fix-qweb-20121218 into lp:c2c-web-addons

[Yannick Vaucher @ Camptocamp]

Add a QWeb variable

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Usually from my observation, the variable QWeb is initialized at the top level of the module's namespace, so it is declared only once for the whole namespace.

I tend to think that we should respect this convention even if we need it only one time in the namespace.
Though, I do not have any formal argument other than convention here, so I let you decide.

Note that if you don't declare a global to the module's namespace, you probably would not need to initialize a local variable but just replace "QWeb.render" by "openerp.web.qweb.render".

review: Approve (no test, review)

[lp:~camptocamp/c2c-web-addons/fix-qweb-20121218]

14. By Yannick Vaucher @ Camptocamp on 2012-12-18

[IMP] web_translate_dialog_page - move QWeb variable at top level of module namespace for convention

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Thanks for the review,

Here we go for some more convention

=== modified file 'web_translate_dialog_page/static/src/js/web_translate_dialog_page.js'
--- web_translate_dialog_page/static/src/js/web_translate_dialog_page.js	2012-10-08 06:04:42 +0000
+++ web_translate_dialog_page/static/src/js/web_translate_dialog_page.js	2012-12-18 17:30:29 +0000
@@ -1,6 +1,7 @@
 openerp.web_translate_dialog_page = function (openerp) {
 
     var _t = openerp.web._t;
+    var QWeb = openerp.web.qweb;
 
     openerp.web.PageView.include({
         on_loaded: function(data) {