Banking Addons

Merge lp:~camptocamp/banking-addons/bank-statement-reconcile_vre into lp:banking-addons/bank-statement-reconcile-70

  1. bank-statement-reconcile_vre
  2. Merge into bank-statement-reconcile-70
Proposed by Guewen Baconnier @ Camptocamp
Status: Merged
Approved by: Alexandre Fayolle - camptocamp
Approved revision: 93
Merged at revision: 93
Proposed branch: lp:~camptocamp/banking-addons/bank-statement-reconcile_vre
Merge into: lp:banking-addons/bank-statement-reconcile-70
Diff against target: 10 lines (+1/-1)
1 file modified
account_advanced_reconcile/advanced_reconciliation.py (+1/-1)
To merge this branch: bzr merge lp:~camptocamp/banking-addons/bank-statement-reconcile_vre
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp Approve
Holger Brunn (Therp) code review Approve
Review via email: mp+168364@code.launchpad.net

This proposal supersedes a proposal from 2013-06-10.

Description of the change

This fix prevent account_advanced_reconcile to crash if ref in the move is not set

To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

The MP is in fact created by Vincent Renaville but I resubmitted it to correct the target branch and it appears now with my name.

I approve this merge.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_advanced_reconcile/advanced_reconciliation.py'
2--- account_advanced_reconcile/advanced_reconciliation.py 2013-01-03 16:37:46 +0000
3+++ account_advanced_reconcile/advanced_reconciliation.py 2013-06-10 07:06:29 +0000
4@@ -114,5 +114,5 @@
5 :yield: matchers as tuple ('matcher key', value(s))
6 """
7 yield ('partner_id', move_line['partner_id'])
8- yield ('ref', (move_line['ref'].lower().strip(),
9+ yield ('ref', ((move_line['ref'] or '').lower().strip(),
10 move_line['name'].lower().strip()))

Subscribers

People subscribed via source and target branches