Merge lp:~camptocamp/banking-addons/bank-statement-reconcile-70-restore_default_value into lp:banking-addons/bank-statement-reconcile-70
Proposed by
Nicolas Bessi - Camptocamp
Status: | Merged |
---|---|
Approved by: | Alexandre Fayolle - camptocamp |
Approved revision: | 89 |
Merged at revision: | 92 |
Proposed branch: | lp:~camptocamp/banking-addons/bank-statement-reconcile-70-restore_default_value |
Merge into: | lp:banking-addons/bank-statement-reconcile-70 |
Diff against target: |
59 lines (+22/-3) (has conflicts) 1 file modified
account_statement_ext/statement.py (+22/-3) Text conflict in account_statement_ext/statement.py |
To merge this branch: | bzr merge lp:~camptocamp/banking-addons/bank-statement-reconcile-70-restore_default_value |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexandre Fayolle - camptocamp | code review, no test, code fix | Approve | |
Guewen Baconnier @ Camptocamp | code review, no test | Needs Fixing | |
Review via email: mp+154650@code.launchpad.net |
Description of the change
Restore default period in bank statement by taking context in account
To post a comment you must log in.
invisible="True" at l.36 is weird, shouldn't it be a boolean instead of a str?
Before l.21 you should ensure that context is a dict.