Merge lp:~camptocamp/banking-addons/bank-statement-reconcile-70-improve-import-usability into lp:banking-addons/bank-statement-reconcile-70
Proposed by
Nicolas Bessi - Camptocamp
Status: | Merged |
---|---|
Merged at revision: | 86 |
Proposed branch: | lp:~camptocamp/banking-addons/bank-statement-reconcile-70-improve-import-usability |
Merge into: | lp:banking-addons/bank-statement-reconcile-70 |
Diff against target: |
216 lines (+77/-33) 3 files modified
account_statement_base_import/parser/file_parser.py (+65/-27) account_statement_base_import/parser/generic_file_parser.py (+9/-4) account_statement_transactionid_import/parser/transactionid_file_parser.py (+3/-2) |
To merge this branch: | bzr merge lp:~camptocamp/banking-addons/bank-statement-reconcile-70-improve-import-usability |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexandre Fayolle - camptocamp | code review, no test | Approve | |
Guewen Baconnier @ Camptocamp | code review, no test | Approve | |
Nicolas Bessi - Camptocamp | Pending | ||
Review via email: mp+151270@code.launchpad.net |
This proposal supersedes a proposal from 2013-02-15.
Description of the change
Improve statement import global usability by retuning usable error message while parsing files.
Allows empty value for float in parsed CSV.
Minor code improvements.
To post a comment you must log in.
Nitpickings
l.30
s/Invalide/invalid/
s/please/Please/
remove extraneous parenthesis around `ftype`
l.40
remove extraneous parenthesis around `col`
l.80,93,113,128
I would recommend the new syntax python3-like for the exceptions as it is more readable
except Exception as err:
BTW, I don't have the context here, but don't we have a more precise exception to catch?
l.147 conversion/
s/convertion/
l.149
return float(val) if val else 0.0