Merge lp:~camptocamp/banking-addons/bank-statement-reconcile-70-imp-statement-import-perf into lp:banking-addons/bank-statement-reconcile-70

[Nicolas Bessi - Camptocamp]

Improve statement import wizard by using mass writing of statement line in order to avoid store field loop computation.

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

l8-9 import of time and profile seems unecessary please delete those.

Otherwise it's fine.

review: Needs Fixing (code, no test)

[lp:~camptocamp/banking-addons/bank-statement-reconcile-70-imp-statement-import-perf]

85. By Nicolas Bessi - Camptocamp on 2013-02-26

[FIX] forgotten code profiling import

[Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount)]

Hello,

You are right. I forgot the profiling import.
Fix committed.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

LGTM

review: Approve (code review, no test)

=== modified file 'account_statement_base_import/statement.py'
--- account_statement_base_import/statement.py	2013-01-29 09:22:10 +0000
+++ account_statement_base_import/statement.py	2013-02-26 08:46:20 +0000
@@ -171,16 +171,19 @@
         try:
             # Record every line in the bank statement and compute the global commission
             # based on the commission_amount column
+            statement_store = []
             for line in result_row_list:
                 parser_vals = parser.get_st_line_vals(line)
                 values = self.prepare_statetement_lines_vals(
                         cr, uid, parser_vals, account_payable,
                         account_receivable, statement_id, context)
                 # we finally create the line in system
-                statement_line_obj.create(cr, uid, values, context=context)
+                statement_store.append((0, 0, values))
             # Build and create the global commission line for the whole statement
-            comm_vals = self.prepare_global_commission_line_vals(
-                    cr, uid, parser, result_row_list, prof, statement_id, context)
+            statement_obj.write(cr, uid, [statement_id],
+                                {'line_ids': statement_store}, context=context)
+            comm_vals = self.prepare_global_commission_line_vals(cr, uid, parser, result_row_list,
+                                                                 prof, statement_id, context)
             if comm_vals:
                 statement_line_obj.create(cr, uid, comm_vals, context=context)