Merge lp:~camptocamp/banking-addons/bank-statement-reconcile-70-fix-completion-error-message into lp:banking-addons/bank-statement-reconcile-70

[Nicolas Bessi - Camptocamp]

Fix of error message + index out of range

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Why do you call exc.__repr__() and not repr(exc)?

[Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount)]

Just the rush. But you right repr(x) will ensure return type in string. It will avoid concatenation error

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

LGTM

review: Approve

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

LGTM

review: Approve (code review, no test)

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

I suggest changing the code of button_auto_completion in the following way:

* change msg from string to a list of strings for efficient appending
* reinit the msg_list for each id of the outer loop

=== modified file 'account_statement_base_completion/statement.py'
--- account_statement_base_completion/statement.py 2013-01-28 12:56:53 +0000
+++ account_statement_base_completion/statement.py 2013-01-30 09:55:41 +0000
@@ -432,9 +432,9 @@
         if context is None:
             context = {}
         stat_line_obj = self.pool.get('account.bank.statement.line')
- msg = ""
         compl_lines = 0
         for stat in self.browse(cr, uid, ids, context=context):
+ msg_lines = []
             ctx = context.copy()
             for line in stat.line_ids:
                 res = {}
@@ -444,14 +444,15 @@
                     if res:
                         compl_lines += 1
                 except ErrorTooManyPartner, exc:
- msg += repr(exc) + "\n"
+ msg_lines.append(repr(exc))
                 except Exception, exc:
- msg += repr(exc) + "\n"
+ msg_lines.append(repr(exc))
                 # vals = res and res.keys() or False
                 if res:
                     vals = res[line.id]
                     vals['already_completed'] = True
                     stat_line_obj.write(cr, uid, [line.id], vals, context=ctx)
- self.write_completion_log(
- cr, uid, stat.id, msg, compl_lines, context=context)
+ msg = u'\n'.join(msg_lines)
+ self.write_completion_log(cr, uid, stat.id,
+ msg, compl_lines, context=context)
         return True

review: Needs Fixing (code review, no test)

[lp:~camptocamp/banking-addons/bank-statement-reconcile-70-fix-completion-error-message]

80. By Alexandre Fayolle - camptocamp on 2013-01-30

[IMP] use a list of lines and join for efficient concatenation, reinit the msg list at the correct place

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

I agree with your change Alexandre

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

review: Approve

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

committed a small improvement.

code LGTM

review: Approve (code review, no test)

=== modified file 'account_statement_base_completion/statement.py'
--- account_statement_base_completion/statement.py	2012-12-20 13:40:22 +0000
+++ account_statement_base_completion/statement.py	2013-01-30 10:02:21 +0000
@@ -286,6 +286,8 @@
             pattern = ".*%s.*" % st_line.label
             cr.execute(sql, (pattern,))
             result = cr.fetchall()
+            if not result:
+                return res
             if len(result) > 1:
                 raise ErrorTooManyPartner(
                         _('Line named "%s" (Ref:%s) was matched by more '
@@ -430,9 +432,9 @@
         if context is None:
             context = {}
         stat_line_obj = self.pool.get('account.bank.statement.line')
-        msg = ""
         compl_lines = 0
         for stat in self.browse(cr, uid, ids, context=context):
+            msg_lines = []
             ctx = context.copy()
             for line in stat.line_ids:
                 res = {}
@@ -442,14 +444,15 @@
                     if res:
                         compl_lines += 1
                 except ErrorTooManyPartner, exc:
-                    msg += exc.value + "\n"
+                    msg_lines.append(repr(exc))
                 except Exception, exc:
-                    msg += exc.value + "\n"
+                    msg_lines.append(repr(exc))
                 # vals = res and res.keys() or False
                 if res:
                     vals = res[line.id]
                     vals['already_completed'] = True
                     stat_line_obj.write(cr, uid, [line.id], vals, context=ctx)
-            self.write_completion_log(
-                    cr, uid, stat.id, msg, compl_lines, context=context)
+            msg = u'\n'.join(msg_lines)
+            self.write_completion_log(cr, uid, stat.id,
+                                  msg, compl_lines, context=context)
         return True