Merge lp:~camptocamp/banking-addons/bank-statement-reconcile-70-fix-1194881 into lp:banking-addons/bank-statement-reconcile-70

[Yannick Vaucher @ Camptocamp]

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Couldn't you just use inv.partner_id.commercial_partner_id?
Anyway invoice.commercial_partner_id is a related to invoice.partner_id.commercial_partner_id

Your fix implies that if you don't install 'account_report_company', it will use the partner of the invoice, which can be a contact. I think that's wrong, you should probably in all cases use invoice.partner_id.commercial_partner_id.

review: Needs Fixing (code review, no test)

[lp:~camptocamp/banking-addons/bank-statement-reconcile-70-fix-1194881]

94. By Virgil Dupras on 2013-07-22

[IMP] Extracted the commission-handling feature from account_statement_base_import to a new module account_statement_commission.

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

account_report_company is in auto_install on account it should then be pulled and installed.

Using inv.partner_id.id is used like in webkit invoice and sale order reports where we kept compatibility with server revision pre 4946 (fixes on res.partner). So at that time commercial_partner_id wasn't in partner.

To solve contact issue, then we should use parent_id to reproduce how commercial_partner_id is computed.

Or I drop the backward compatibility and then I think we can expect account_report_company to be always installed.

[lp:~camptocamp/banking-addons/bank-statement-reconcile-70-fix-1194881]

95. By Vincent Renaville@camptocamp on 2013-08-12

[FIX] fix report lang

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Thanks for the explanation, sounds good.

review: Approve (code review, no test)

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Can someone give the final approve and merge please.

[Romain Deheele - Camptocamp (romaindeheele)]

LGTM,

Romain

review: Approve (code review, no test)

[lp:~camptocamp/banking-addons/bank-statement-reconcile-70-fix-1194881]

96. By Yannick Vaucher @ Camptocamp on 2013-10-15

[MRG] improve aspect of the reconcile button

97. By Yannick Vaucher @ Camptocamp on 2013-10-15

[MRG] account_statement_ext improvements

docstring for Statement default profile
hide type column in bank statement line
add a sequence on bank profile and set the first of the company as default
hide useless information on bank statement
move profile to top
simplify xpath in xml views
rename profil to profile

98. By Yannick Vaucher @ Camptocamp on 2013-10-15

[MRG][FIX] account_statement_base_completion - use invoice commercial_partner_id instead of partner

=== modified file 'account_statement_base_completion/statement.py'
--- account_statement_base_completion/statement.py	2013-04-30 09:51:39 +0000
+++ account_statement_base_completion/statement.py	2013-06-26 13:50:53 +0000
@@ -178,7 +178,15 @@
         res = {}
         inv = self._find_invoice(cr, uid, line, inv_type, context=context)
         if inv:
-            res = {'partner_id': inv.partner_id.id,
+            # FIXME use only commercial_partner_id of invoice in 7.1
+            # this is for backward compatibility in 7.0 before 
+            # the refactoring of res.partner
+            if hasattr(inv, 'commercial_partner_id'):
+                partner_id = inv.commercial_partner_id.id
+            else:
+                partner_id = inv.partner_id.id
+
+            res = {'partner_id': partner_id,
                    'account_id': inv.account_id.id,
                    'type': inv_type}
             override_acc = line['master_account_id']