Merge lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-fix-onchange-lep into lp:banking-addons/bank-statement-reconcile-70

Proposed by Leonardo Pistone
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 108
Merged at revision: 109
Proposed branch: lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-fix-onchange-lep
Merge into: lp:banking-addons/bank-statement-reconcile-70
Diff against target: 17 lines (+1/-5)
1 file modified
account_statement_ext/statement.py (+1/-5)
To merge this branch: bzr merge lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-fix-onchange-lep
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no tests Approve
Romain Deheele - Camptocamp (community) code review Approve
Guewen Baconnier @ Camptocamp code review Approve
Review via email: mp+199518@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM
Thanks

review: Approve (code review)
Revision history for this message
Romain Deheele - Camptocamp (romaindeheele) wrote :

LGTM,

Romain

review: Approve (code review)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Ok those fields are not present in http://bazaar.launchpad.net/~banking-addons-team/banking-addons/bank-statement-reconcile-70/view/head:/account_statement_ext/statement_view.xml (I was unsure about what hidden field meant in comment)

LGTM

Thanks Leonardo

review: Approve (code review, no tests)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_statement_ext/statement.py'
2--- account_statement_ext/statement.py 2013-12-11 16:01:01 +0000
3+++ account_statement_ext/statement.py 2013-12-18 18:13:29 +0000
4@@ -552,12 +552,8 @@
5 import_config = self.pool.get("account.statement.profile").browse(
6 cr, uid, profile_id, context=context)
7 journal_id = import_config.journal_id.id
8- account_id = import_config.journal_id.default_debit_account_id.id
9- credit_partner_id = import_config.partner_id and import_config.partner_id.id or False
10 return {'value': {'journal_id': journal_id,
11- 'account_id': account_id,
12- 'balance_check': import_config.balance_check,
13- 'credit_partner_id': credit_partner_id}}
14+ 'balance_check': import_config.balance_check}}
15
16
17 class AccountBankSatementLine(Model):

Subscribers

People subscribed via source and target branches