Merge lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-fix-default-lep into lp:banking-addons/bank-statement-reconcile-70

Proposed by Leonardo Pistone
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 138
Merged at revision: 138
Proposed branch: lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-fix-default-lep
Merge into: lp:banking-addons/bank-statement-reconcile-70
Diff against target: 20 lines (+2/-1)
1 file modified
account_statement_base_import/statement.py (+2/-1)
To merge this branch: bzr merge lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-fix-default-lep
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no test Approve
Nicolas Bessi - Camptocamp (community) no test, code review Approve
Alexandre Fayolle - camptocamp code review, no test Approve
Review via email: mp+213682@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

LGTM

review: Approve (code review, no test)
Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote :

LGTM

review: Approve (no test, code review)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

LGTM

review: Approve (code review, no test)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_statement_base_import/statement.py'
2--- account_statement_base_import/statement.py 2014-03-06 09:40:57 +0000
3+++ account_statement_base_import/statement.py 2014-04-01 16:02:24 +0000
4@@ -110,6 +110,7 @@
5 :return: dict of vals that will be passed to create method of statement line.
6 """
7 statement_obj = self.pool.get('account.bank.statement')
8+ statement_line_obj = self.pool['account.bank.statement.line']
9 values = parser_vals
10 values['statement_id'] = statement_id
11 values['account_id'] = statement_obj.get_account_for_counterpart(cr,
12@@ -132,7 +133,7 @@
13 context=context)
14 values['period_id'] = periods[0]
15 period_memoizer[date] = periods[0]
16- values['type'] = 'general'
17+ values = statement_line_obj._add_missing_default_values(cr, uid, values, context)
18 return values
19
20 def prepare_statement_vals(self, cr, uid, profile_id, result_row_list, parser, context):

Subscribers

People subscribed via source and target branches