lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-fix-1313689
- Get this branch:
- bzr branch lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-fix-1313689
Branch merges
- Laurent Mignon (Acsone) (community): Approve (code veview, no tests)
- Joël Grand-Guillaume @ camptocamp: Approve (code review, no tests)
- Banking Addons Core Editors: Pending requested
-
Diff: 108 lines (+25/-17)2 files modifiedaccount_statement_base_completion/statement.py (+23/-0)
account_statement_base_import/statement.py (+2/-17)
Related bugs
Related blueprints
Branch information
Recent revisions
- 149. By Yannick Vaucher @ Camptocamp
-
remove account_payable and account_receivable from prepare_
statement_ vals args as not used anymore - 147. By Yannick Vaucher @ Camptocamp
-
prepare values by calling _symbol_f on values to ensure we don't insert bad values
- 146. By Yannick Vaucher @ Camptocamp
-
set account_id optional in account_
statement_ base_completion instead of account_ statement_ base_import - 145. By Launchpad Translations on behalf of banking-addons-team
-
Launchpad automatic translations update.
- 144. By Guewen Baconnier @ Camptocamp
-
[FIX] too many characters are escaped, leading to an 'invalid regular expression: invalid escape \ sequence' error.
- 143. By Sébastien BEAU - http://www.akretion.com
-
[REF] account_id is not anymore mandatory for creating a bank statement line. Still mandatory for the validation
- 142. By Launchpad Translations on behalf of banking-addons-team
-
Launchpad automatic translations update.
- 141. By Guewen Baconnier @ Camptocamp
-
Improvement around the Transaction IDs modules
============== ======= ======= ======= ======= ==== This proposal aims to improve the modules using transaction ids, I will start
by summarizing what are they used for, then what are the existing problems and
what changes I propose.Transaction IDs?
----------------The transaction IDs are a technical reference for a move line. They are to
differentiate from the usual reference that are a reference for humans firstly
(more about that here [0]). Usually, the transaction IDs are defined by
external systems such as payment gateways and are a way to streamline the
reconciliations between the invoices, bank statements...Changes
-------1) account_
move_line. transaction_ ref is defined in 'account_ advanced_ reconcile_ transaction_ ref' which adds a reconciliation method with transaction id.
It makes much sense to add the field in 'base_transaction_id' so we can use the field in other modules such as the bank statement completion modules. It is a pity that the field on the invoice and the sale order is 'transaction_id' and in move lines 'transaction_ref' but I prefer to keep the backward- compatibility. So I moved these things from 'account_
advanced_ reconcile_ transaction_ ref' to 'base_transacti on_id' 2) In account_
advanced_ reconcile_ transaction_ ref there is an inherit of the bank statement that copies the line's ref in the move line's transaction_id. I think this is a mismatch between the ref and the transaction_id that we have to avoid. In fact, only the transaction id of the statement lines should be copied if any, or left empty if the statement line has no transaction id. 3) A consequence of the change 2) is that the automatic reconcile from transaction ref will no longer work for those not using the transaction ids in the bank statement but only the ref. So I added a new reconciliation rule that matches 'ref' vs 'transaction id'. The only drawback is that they will need to change their configuration, but at least the rules will be clear on their intentions.
4) completion rules: 'base_transacti
on_id' adds a transaction_id on sales order and invoices. There is actually a completion rule that searches the bank statement information from a matching invoice with the same transaction_id. I added the same rule that searches for an invoice with the same transaction id. This is the logical continuation and a good complement when an invoice / refund was not generated by a sales order and we still need to autocomplete the bank statement. - 140. By Launchpad Translations on behalf of banking-addons-team
-
Launchpad automatic translations update.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:banking-addons