Banking Addons

Merge lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-could-not-determine-delimiters-1285075 into lp:banking-addons/bank-statement-reconcile-70

  1. bank-statement-reconcile-7.0-could-not-determine-delimiters-1285075
  2. Merge into bank-statement-reconcile-70
Proposed by Guewen Baconnier @ Camptocamp
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 124
Merged at revision: 124
Proposed branch: lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-could-not-determine-delimiters-1285075
Merge into: lp:banking-addons/bank-statement-reconcile-70
Diff against target: 12 lines (+1/-1)
1 file modified
account_statement_base_import/parser/parser.py (+1/-1)
To merge this branch: bzr merge lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-could-not-determine-delimiters-1285075
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no tests Approve
Laurent Mignon (Acsone) (community) code review Approve
Leonardo Pistone Approve
Pedro Manuel Baeza code review Approve
Review via email: mp+208322@code.launchpad.net

Description of the change

Details on the bug report: lp:1285075

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Thanks for the patch!

Regards.

review: Approve (code review)
Revision history for this message
Leonardo Pistone (lepistone) wrote :

ok!

review: Approve
Revision history for this message
Laurent Mignon (Acsone) (lmi) wrote :

Hope it will be sufficient for all cases now. Thanks.

Regards.

review: Approve (code review)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

LGTM

Sounds reasonable

review: Approve (code review, no tests)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_statement_base_import/parser/parser.py'
2--- account_statement_base_import/parser/parser.py 2014-01-21 16:46:36 +0000
3+++ account_statement_base_import/parser/parser.py 2014-02-26 10:26:29 +0000
4@@ -25,7 +25,7 @@
5 def UnicodeDictReader(utf8_data, **kwargs):
6 sniffer = csv.Sniffer()
7 pos = utf8_data.tell()
8- sample_data = utf8_data.read(1024)
9+ sample_data = utf8_data.read(2048)
10 utf8_data.seek(pos)
11 dialect = sniffer.sniff(sample_data, delimiters=',;\t')
12 csv_reader = csv.DictReader(utf8_data, dialect=dialect, **kwargs)

Subscribers

People subscribed via source and target branches