Code review comment for lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-add-cancel-line-lep

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Thanks for considering account_banking for your naming! Having this module will certainly help in merging the projects.

I tried to test the module, and was confronted by the dependency on account_default_draft_move. This dependency enforces alternative accounting practises which may be required in your region, but not in ours and should not be part of this change IMHO. Would you consider making this module agnostic towards the cancelling draft moves? With this, I mean that when cancelling a bank statement line, you can simply attempt to cancel and remove the associated move line and do the constraints in the various modules do their work.

review: Needs Information

« Back to merge proposal