Merge lp:~camptocamp/account-invoicing/account-analytic-required-vre into lp:~account-core-editors/account-invoicing/7.0

Proposed by Vincent Renaville@camptocamp
Status: Needs review
Proposed branch: lp:~camptocamp/account-invoicing/account-analytic-required-vre
Merge into: lp:~account-core-editors/account-invoicing/7.0
Diff against target: 239 lines (+203/-0)
7 files modified
account_invoice_analytic_required/__init__.py (+23/-0)
account_invoice_analytic_required/__openerp__.py (+38/-0)
account_invoice_analytic_required/account_invoice_analytic_required.py (+31/-0)
account_invoice_analytic_required/i18n/account_invoice_analytic_required.pot (+27/-0)
account_invoice_analytic_required/i18n/es.po (+30/-0)
account_invoice_analytic_required/i18n/fr_BE.po (+27/-0)
account_invoice_analytic_required/i18n/sv.po (+27/-0)
To merge this branch: bzr merge lp:~camptocamp/account-invoicing/account-analytic-required-vre
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza Needs Resubmitting
Lorenzo Battistini (community) Needs Fixing
Holger Brunn (Therp) code review Needs Fixing
Review via email: mp+218974@code.launchpad.net

Description of the change

Hello,

The account_invoice_analytic_required force the user to specify an analytic account on invoice line

Vincent

To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

#60 sale.invoice.line?
#104 _description is not necessary here
#180ff you should remove translation files that don't actually contain translations

And per default, the field is only visible for analytic.group_analytic_accounting. I think this addon should remove this group from the view definition.

review: Needs Fixing (code review)
Revision history for this message
Lorenzo Battistini (elbati) wrote :

Thanks Vincent,

some style fixes:

account_invoice_analytic_required/__init__.py:3:2: W291 trailing whitespace
account_invoice_analytic_required/__init__.py:19:75: W291 trailing whitespace
account_invoice_analytic_required/__init__.py:23:14: E271 multiple spaces after keyword
account_invoice_analytic_required/__openerp__.py:3:2: W291 trailing whitespace
account_invoice_analytic_required/__openerp__.py:19:75: W291 trailing whitespace
account_invoice_analytic_required/__openerp__.py:23:1: O603 Manifest "license" key is missing
account_invoice_analytic_required/__openerp__.py:24:11: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:25:14: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:26:15: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:28:13: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:29:14: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:30:14: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:32:11: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:33:11: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:34:11: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:35:18: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:36:19: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:37:18: E203 whitespace before ':'
account_invoice_analytic_required/account_invoice_analytic_required.py:23:1: O603 Manifest "license" key is missing
account_invoice_analytic_required/account_invoice_analytic_required.py:25:1: E302 expected 2 blank lines, found 1
account_invoice_analytic_required/account_invoice_analytic_required.py:27:13: E225 missing whitespace around operator

account_invoice_analytic_required/__openerp__.py:24:80: E501 line too long (84 > 79 characters)
account_invoice_analytic_required/__openerp__.py:27:80: E501 line too long (94 > 79 characters)
account_invoice_analytic_required/account_invoice_analytic_required.py:30:80: E501 line too long (110 > 79 characters)

review: Needs Fixing
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

This project is now hosted on https://github.com/OCA/account-invoicing. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting

Unmerged revisions

47. By Vincent Renaville@camptocamp on 2014-05-09

[ADD] account_invoice_analytic_required : this modules force the user to specificed a analytic account on invoice line

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'account_invoice_analytic_required'
2=== added file 'account_invoice_analytic_required/__init__.py'
3--- account_invoice_analytic_required/__init__.py 1970-01-01 00:00:00 +0000
4+++ account_invoice_analytic_required/__init__.py 2014-05-09 12:02:43 +0000
5@@ -0,0 +1,23 @@
6+# -*- encoding: utf-8 -*-
7+##############################################################################
8+#
9+# OpenERP, Open Source Management Solution
10+# Copyright (C) 2004-2009 Tiny SPRL (<http://tiny.be>).
11+# Copyright (c) 2014 Camptocamp SA (http://www.camptocamp.com)
12+#
13+# This program is free software: you can redistribute it and/or modify
14+# it under the terms of the GNU Affero General Public License as
15+# published by the Free Software Foundation, either version 3 of the
16+# License, or (at your option) any later version.
17+#
18+# This program is distributed in the hope that it will be useful,
19+# but WITHOUT ANY WARRANTY; without even the implied warranty of
20+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21+# GNU Affero General Public License for more details.
22+#
23+# You should have received a copy of the GNU Affero General Public License
24+# along with this program. If not, see <http://www.gnu.org/licenses/>.
25+#
26+##############################################################################
27+
28+from . import account_invoice_analytic_required
29
30=== added file 'account_invoice_analytic_required/__openerp__.py'
31--- account_invoice_analytic_required/__openerp__.py 1970-01-01 00:00:00 +0000
32+++ account_invoice_analytic_required/__openerp__.py 2014-05-09 12:02:43 +0000
33@@ -0,0 +1,38 @@
34+# -*- encoding: utf-8 -*-
35+##############################################################################
36+#
37+# OpenERP, Open Source Management Solution
38+# Copyright (C) 2004-2009 Tiny SPRL (<http://tiny.be>).
39+# Copyright (c) 2014 Camptocamp SA (http://www.camptocamp.com)
40+#
41+# This program is free software: you can redistribute it and/or modify
42+# it under the terms of the GNU Affero General Public License as
43+# published by the Free Software Foundation, either version 3 of the
44+# License, or (at your option) any later version.
45+#
46+# This program is distributed in the hope that it will be useful,
47+# but WITHOUT ANY WARRANTY; without even the implied warranty of
48+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
49+# GNU Affero General Public License for more details.
50+#
51+# You should have received a copy of the GNU Affero General Public License
52+# along with this program. If not, see <http://www.gnu.org/licenses/>.
53+#
54+##############################################################################
55+
56+{
57+ 'name' : 'Make Account invoice analytic account required in sale.invoice.line.',
58+ 'version' : '1.0',
59+ 'category' : 'Generic Modules/Accounting',
60+ 'description': '''Module to make analytic account field required in sale.invoice.line.''',
61+ 'author' : 'OpenERP SA/Camptocamp SA',
62+ 'website' : 'http://www.camptocamp.com',
63+ 'depends' : ['base',
64+ 'account'],
65+ 'data' : [],
66+ 'demo' : [],
67+ 'test' : [],
68+ 'installable' : True,
69+ 'auto_install' : False,
70+ 'application' : True,
71+}
72
73=== added file 'account_invoice_analytic_required/account_invoice_analytic_required.py'
74--- account_invoice_analytic_required/account_invoice_analytic_required.py 1970-01-01 00:00:00 +0000
75+++ account_invoice_analytic_required/account_invoice_analytic_required.py 2014-05-09 12:02:43 +0000
76@@ -0,0 +1,31 @@
77+# -*- encoding: utf-8 -*-
78+##############################################################################
79+#
80+# OpenERP, Open Source Management Solution
81+# Copyright (C) 2004-2009 Tiny SPRL (<http://tiny.be>).
82+# Copyright (c) 2014 Camptocamp SA (http://www.camptocamp.com)
83+#
84+# This program is free software: you can redistribute it and/or modify
85+# it under the terms of the GNU Affero General Public License as
86+# published by the Free Software Foundation, either version 3 of the
87+# License, or (at your option) any later version.
88+#
89+# This program is distributed in the hope that it will be useful,
90+# but WITHOUT ANY WARRANTY; without even the implied warranty of
91+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
92+# GNU Affero General Public License for more details.
93+#
94+# You should have received a copy of the GNU Affero General Public License
95+# along with this program. If not, see <http://www.gnu.org/licenses/>.
96+#
97+##############################################################################
98+
99+from openerp.osv import orm, fields
100+
101+class account_invoice_line(orm.Model):
102+ _name = 'account.invoice.line'
103+ _inherit='account.invoice.line'
104+ _description = 'Invoice line'
105+ _columns = {
106+ 'account_analytic_id': fields.many2one('account.analytic.account', 'Analytic Account', required=True),
107+ }
108
109=== added directory 'account_invoice_analytic_required/i18n'
110=== added file 'account_invoice_analytic_required/i18n/account_invoice_analytic_required.pot'
111--- account_invoice_analytic_required/i18n/account_invoice_analytic_required.pot 1970-01-01 00:00:00 +0000
112+++ account_invoice_analytic_required/i18n/account_invoice_analytic_required.pot 2014-05-09 12:02:43 +0000
113@@ -0,0 +1,27 @@
114+# Translation of OpenERP Server.
115+# This file contains the translation of the following modules:
116+# * account_invoice_analytic_required
117+#
118+msgid ""
119+msgstr ""
120+"Project-Id-Version: OpenERP Server 5.0.6\n"
121+"Report-Msgid-Bugs-To: support@openerp.com\n"
122+"POT-Creation-Date: 2009-11-24 13:15:30+0000\n"
123+"PO-Revision-Date: 2009-11-24 13:15:30+0000\n"
124+"Last-Translator: <>\n"
125+"Language-Team: \n"
126+"MIME-Version: 1.0\n"
127+"Content-Type: text/plain; charset=UTF-8\n"
128+"Content-Transfer-Encoding: \n"
129+"Plural-Forms: \n"
130+
131+#. module: account_invoice_analytic_required
132+#: model:ir.module.module,shortdesc:account_invoice_analytic_required.module_meta_information
133+msgid "Account invoice analytic required"
134+msgstr ""
135+
136+#. module: account_invoice_analytic_required
137+#: model:ir.module.module,description:account_invoice_analytic_required.module_meta_information
138+msgid "Module to make analytic account field required in sale.invoice.line."
139+msgstr ""
140+
141
142=== added file 'account_invoice_analytic_required/i18n/es.po'
143--- account_invoice_analytic_required/i18n/es.po 1970-01-01 00:00:00 +0000
144+++ account_invoice_analytic_required/i18n/es.po 2014-05-09 12:02:43 +0000
145@@ -0,0 +1,30 @@
146+# Spanish translation for openobject-addons
147+# Copyright (c) 2011 Rosetta Contributors and Canonical Ltd 2011
148+# This file is distributed under the same license as the openobject-addons package.
149+# FIRST AUTHOR <EMAIL@ADDRESS>, 2011.
150+#
151+msgid ""
152+msgstr ""
153+"Project-Id-Version: openobject-addons\n"
154+"Report-Msgid-Bugs-To: FULL NAME <EMAIL@ADDRESS>\n"
155+"POT-Creation-Date: 2009-11-24 13:15+0000\n"
156+"PO-Revision-Date: 2011-02-15 15:01+0000\n"
157+"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
158+"Language-Team: Spanish <es@li.org>\n"
159+"MIME-Version: 1.0\n"
160+"Content-Type: text/plain; charset=UTF-8\n"
161+"Content-Transfer-Encoding: 8bit\n"
162+"X-Launchpad-Export-Date: 2011-08-13 05:35+0000\n"
163+"X-Generator: Launchpad (build 13674)\n"
164+
165+#. module: account_invoice_analytic_required
166+#: model:ir.module.module,shortdesc:account_invoice_analytic_required.module_meta_information
167+msgid "Account invoice analytic required"
168+msgstr "Requerida cuenta analítica en factura"
169+
170+#. module: account_invoice_analytic_required
171+#: model:ir.module.module,description:account_invoice_analytic_required.module_meta_information
172+msgid "Module to make analytic account field required in sale.invoice.line."
173+msgstr ""
174+"Módulo para hacer que la cuenta analítica sea requerida en la línea de "
175+"factura"
176
177=== added file 'account_invoice_analytic_required/i18n/fr_BE.po'
178--- account_invoice_analytic_required/i18n/fr_BE.po 1970-01-01 00:00:00 +0000
179+++ account_invoice_analytic_required/i18n/fr_BE.po 2014-05-09 12:02:43 +0000
180@@ -0,0 +1,27 @@
181+# Translation of OpenERP Server.
182+# This file contains the translation of the following modules:
183+# * account_invoice_analytic_required
184+#
185+msgid ""
186+msgstr ""
187+"Project-Id-Version: OpenERP Server 5.0.6\n"
188+"Report-Msgid-Bugs-To: support@openerp.com\n"
189+"POT-Creation-Date: 2009-11-24 13:15:30+0000\n"
190+"PO-Revision-Date: 2009-11-24 13:15:30+0000\n"
191+"Last-Translator: <>\n"
192+"Language-Team: \n"
193+"MIME-Version: 1.0\n"
194+"Content-Type: text/plain; charset=UTF-8\n"
195+"Content-Transfer-Encoding: \n"
196+"Plural-Forms: \n"
197+
198+#. module: account_invoice_analytic_required
199+#: model:ir.module.module,shortdesc:account_invoice_analytic_required.module_meta_information
200+msgid "Account invoice analytic required"
201+msgstr ""
202+
203+#. module: account_invoice_analytic_required
204+#: model:ir.module.module,description:account_invoice_analytic_required.module_meta_information
205+msgid "Module to make analytic account field required in sale.invoice.line."
206+msgstr ""
207+
208
209=== added file 'account_invoice_analytic_required/i18n/sv.po'
210--- account_invoice_analytic_required/i18n/sv.po 1970-01-01 00:00:00 +0000
211+++ account_invoice_analytic_required/i18n/sv.po 2014-05-09 12:02:43 +0000
212@@ -0,0 +1,27 @@
213+# Translation of OpenERP Server.
214+# This file contains the translation of the following modules:
215+# * account_invoice_analytic_required
216+#
217+msgid ""
218+msgstr ""
219+"Project-Id-Version: OpenERP Server 5.0.14\n"
220+"Report-Msgid-Bugs-To: support@openerp.com\n"
221+"POT-Creation-Date: 2009-11-24 13:15+0000\n"
222+"PO-Revision-Date: 2011-02-15 15:01+0000\n"
223+"Last-Translator: Olivier Dony (OpenERP) <Unknown>\n"
224+"Language-Team: \n"
225+"MIME-Version: 1.0\n"
226+"Content-Type: text/plain; charset=UTF-8\n"
227+"Content-Transfer-Encoding: 8bit\n"
228+"X-Launchpad-Export-Date: 2011-08-13 05:35+0000\n"
229+"X-Generator: Launchpad (build 13674)\n"
230+
231+#. module: account_invoice_analytic_required
232+#: model:ir.module.module,shortdesc:account_invoice_analytic_required.module_meta_information
233+msgid "Account invoice analytic required"
234+msgstr ""
235+
236+#. module: account_invoice_analytic_required
237+#: model:ir.module.module,description:account_invoice_analytic_required.module_meta_information
238+msgid "Module to make analytic account field required in sale.invoice.line."
239+msgstr "Module to make analytic account field required in sale.invoice.line."

Subscribers

People subscribed via source and target branches