Merge lp:~camptocamp/account-invoice-report/fix-css into lp:~account-core-editors/account-invoice-report/7.0

Proposed by Nicolas Bessi - Camptocamp
Status: Merged
Merge reported by: Joël Grand-Guillaume @ camptocamp
Merged at revision: not available
Proposed branch: lp:~camptocamp/account-invoice-report/fix-css
Merge into: lp:~account-core-editors/account-invoice-report/7.0
Diff against target: 21 lines (+2/-2)
1 file modified
invoice_webkit/report/account_invoice.mako (+2/-2)
To merge this branch: bzr merge lp:~camptocamp/account-invoice-report/fix-css
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp code review, no test Approve
Review via email: mp+145869@code.launchpad.net

Description of the change

Fix padding left of HTML notes, we have to put style directly inside <TD> else it is not taken in account

To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

the 2nd part of your comment is weird. Looks like conflicting selectors, which could be fixed in the css.

Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote :

I have looked quite a time in CSS. The class is applied on the lower level item (the cell). I try to fix the CSS without success. In debug mode I did not find any broken HTML tags and css is correctly applied if rendered in browser. It looks like a wkhtml2pdf trouble.

Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

OK. LGTM, then...

review: Approve (code review, no test)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'invoice_webkit/report/account_invoice.mako'
2--- invoice_webkit/report/account_invoice.mako 2013-01-30 15:34:53 +0000
3+++ invoice_webkit/report/account_invoice.mako 2013-01-31 14:16:26 +0000
4@@ -34,7 +34,7 @@
5 border-right:thin solid #EEEEEE;
6 border-left:thin solid #EEEEEE;
7 border-top:thin solid #EEEEEE;
8- left:10px;
9+ padding-left:10px;
10 font-size:smaller;
11 }
12
13@@ -242,7 +242,7 @@
14 </tr>
15 %if line.formatted_note:
16 <tr>
17- <td class="formatted_note" colspan="7">
18+ <td class="formatted_note" style="padding-left:10px" colspan="7">
19 ${line.formatted_note| n}
20 </td>
21 <tr>

Subscribers

People subscribed via source and target branches