Merge lp:~camptocamp/account-invoice-report/better-invoice-line-layout into lp:~account-core-editors/account-invoice-report/7.0

[Nicolas Bessi - Camptocamp]

Remove product for invoice line list view as it is not shown in report and line is editable in form mode. It may also avoid nasty layout overlapping.

We also neutralize the product_id on change in list view.

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

LGTM

review: Approve

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

Hello Alexandre,

a minor remark: you could be less brutal than replace and use
position="attributes" instead of position="replace"
and then inside the field:
<attribute name="invisible">1</attribute>

It's a bit more robust if product_id has been customized some way.

LGBT aussi

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

I agree with Raphaël. I would consider the full replacement of the field as a bad practice versus to change only the attribute.

l.9: typo s/imporve/improve/

review: Needs Fixing

[lp:~camptocamp/account-invoice-report/better-invoice-line-layout]

24. By Guewen Baconnier @ Camptocamp on 2013-03-04

[FIX] do not replace completely the field, change the 'invisible' attribute instead

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Made the changes

review: Approve

=== modified file 'invoice_webkit/view/invoice_view.xml'
--- invoice_webkit/view/invoice_view.xml	2013-01-31 13:06:26 +0000
+++ invoice_webkit/view/invoice_view.xml	2013-03-04 06:53:23 +0000
@@ -99,5 +99,16 @@
       </field>
     </record>
 
+    <record model="ir.ui.view" id="invoice_improve_line_tree">
+      <field name="name">account.invoiceline.improve.line</field>
+      <field name="model">account.invoice</field>
+      <field name="inherit_id" ref="account.invoice_form"/>
+      <field name="arch" type="xml">
+        <xpath expr="//field[@name='invoice_line']/tree/field[@name='product_id']" position="attributes">
+          <attribute name="invisible">1</attribute>
+        </xpath>
+      </field>
+    </record>
+
   </data>
 </openerp>